UL&S: bug fix: make the TextLinkButtonTableViewCell button word wrap, not truncate #310
Conversation
|
|
||
| button.titleLabel?.font = UIFont.preferredFont(forTextStyle: .callout) | ||
| button.titleLabel?.adjustsFontForContentSizeCategory = true | ||
| button.titleLabel?.lineBreakMode = .byWordWrapping |
There was a problem hiding this comment.
Just a thought here: since you're using a xib, it would be nice to set these at design time, although, for a UIButton is less obvious, since you don't have the 'adjustsFontForContentSizeCategoryreadily available. You might still set the font and line break mode in there. You could also setadjustsFontForContentSizeCategoryin there using@ibdesignable` (which I don't think is worth) or trying to set that value as a user defined runtime attribute (but it would still be a runtime calculation). Again it's just a thought, there's nothing wrong in leaving as it is.
There was a problem hiding this comment.
Okie dokie, I moved setting the font and lineBreakMode to the Interface Builder. ajustsFontForContentSizeCategory is a variable in the UIContentSizeCategoryAdjusting protocol. Protocol variables don't seem to work with @IBInspectable or @IBDesignable, so I left it as-is.
There was a problem hiding this comment.
I agree with @Gio2018 - it'd be nice if those settings were in the xib, but not a big deal. Otherwise looks good!
Ref #283
Per #308, there is a bug where the button title text was truncating. This PR fixes the truncation.
PR to test fix: wordpress-mobile/WordPress-iOS#14385
Before:
After:
