Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Authenticator delegate #14

Merged
merged 4 commits into from
Jul 12, 2018

Conversation

jleandroperez
Copy link
Contributor

Details:

Just a little bit of housekeeping: the method sync has a closure callback, which expects an Error optional. However: such parameter is never, not ever used.

In this PR we're simply dropping such parameter.

Testing:

Please refer to this WPiOS PR for testing steps.

Thanks in advance!!

@jleandroperez jleandroperez self-assigned this Jul 11, 2018
Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mindgraffiti mindgraffiti added the enhancement New feature or request label Jul 12, 2018
@mindgraffiti mindgraffiti added this to the 1.0.2 milestone Jul 12, 2018
@jleandroperez jleandroperez merged commit f04d9bf into develop Jul 12, 2018
@jleandroperez jleandroperez deleted the issue/updating-authenticator-delegate branch July 12, 2018 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants