Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reachability checks from Social Connections #23983

Merged
merged 1 commit into from
Jan 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -232,11 +232,6 @@ - (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath

- (void)handleConnectTapped:(NSIndexPath *)indexPath
{
if (![ReachabilityUtils isInternetReachable]) {
[ReachabilityUtils showAlertNoInternetConnection];
return;
}

if ([UIDevice isPad]) {
UITableViewCell *cell = [self.tableView cellForRowAtIndexPath:indexPath];
self.helper.popoverSourceView = cell.textLabel;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -238,11 +238,6 @@ - (void)updateSharedGlobally:(BOOL)shared

- (void)reconnectPublicizeConnection
{
if (![ReachabilityUtils isInternetReachable]) {
[ReachabilityUtils showAlertNoInternetConnection];
return;
}

SharingService *sharingService = [[SharingService alloc] initWithContextManager:[ContextManager sharedInstance]];

__weak __typeof(self) weakSelf = self;
Expand Down Expand Up @@ -273,11 +268,6 @@ - (void)disconnectPublicizeConnection

- (void)promptToConfirmDisconnect
{
if (![ReachabilityUtils isInternetReachable]) {
[ReachabilityUtils showAlertNoInternetConnection];
return;
}

NSString *message = NSLocalizedString(@"Disconnecting this account means published posts will no longer be automatically shared to %@", @"Explanatory text for the user. The `%@` is a placeholder for the name of a third-party sharing service.");
message = [NSString stringWithFormat:message, self.publicizeConnection.label];
UIAlertController *alert = [UIAlertController alertControllerWithTitle:nil
Expand Down
Loading