Address remaining feedback for 25.7. #23977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23977-eca3768 | |
| Version | 25.6 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | eca3768 | |
| App Center Build | WPiOS - One-Offs #11348 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23977-eca3768 | |
| Version | 25.6 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | eca3768 | |
| App Center Build | jetpack-installable-builds #10379 |
crazytonyli
requested changes
Jan 15, 2025
| @@ -89,6 +89,7 @@ public final class ImagePrefetcher { | |||
| value.task?.cancel() | |||
| } | |||
| queue.removeAll() | |||
| numberOfActiveTasks = 0 | |||
There was a problem hiding this comment.
I believe numberOfActiveTasks needs to be updated in stopPrefetching too.
There was a problem hiding this comment.
stopPrefetching cancel the task task.task?.cancel() but doesn't manually manipulate the queue. The task will then need to cancel or run until the completion depending what's state it's in. So updating numberOfActiveTasks is not needed there. This is the part I did test (manually). I didn't test stopAll though because it's not used anywhere.
There was a problem hiding this comment.
Oh. I see it now. numberOfActiveTasks is updated in the actuallyPrefetchImage task when the task is cancelled.
| /// Initializes the struct with given size in **pixels**. | ||
| public init(width: Int, height: Int) { | ||
| self.width = Int(width) | ||
| self.height = Int(height) |
There was a problem hiding this comment.
Int(...) is not needed.
crazytonyli
approved these changes
Jan 15, 2025
jkmassel
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Update ImageSize to use Int * Add ImageSize(pixels:) and document APIs * Rework ImageSize convenience APIs * Make ImageSize properties writable * Add note about deprecating passTouchesToSuperview * Fix stopAll * Remove redundant init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: