Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable quick access to notifications from Reader #23882

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Enable quick access to notifications from Reader #23882

merged 3 commits into from
Dec 11, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Dec 10, 2024

Fixes #23717 by adding the "Notifications" bell directly to the main Reader screens. If the app re-opens on one of these screens thanks to state restoration, you will see the bell regardless of whether the menu is opened or the orientation. The bell provides instant information: do I have any new notifications? It also allows you to glance over the newest notifications quickly.

Screenshot 2024-12-10 at 2 28 55 PM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Reader label Dec 10, 2024
@kean kean added this to the 25.6 milestone Dec 10, 2024
@kean kean requested a review from crazytonyli December 10, 2024 19:49
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.6. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 10, 2024 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23882-c3c7264
Version25.5
Bundle IDorg.wordpress.alpha
Commitc3c7264
App Center BuildWPiOS - One-Offs #11161
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 10, 2024 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23882-c3c7264
Version25.5
Bundle IDcom.jetpack.alpha
Commitc3c7264
App Center Buildjetpack-installable-builds #10200
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

crazytonyli
crazytonyli approved these changes Dec 10, 2024
View reviewed changes
WordPress/Classes/ViewRelated/Reader/Controllers/ReaderDiscoverViewController.swift Outdated
private func setupNotificationsBarButtonItem() {
notificationsButtonCancellable = nil
if traitCollection.horizontalSizeClass == .regular {
notificationsButtonCancellable = notificationsButtonViewModel.$image.sink { [weak self] in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few whitespaces after =.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; didn't notice it with the way my editor is set up. Fixed.

WordPress/Classes/ViewRelated/Reader/Controllers/ReaderStreamViewController.swift Outdated
private func setupNotificationsBarButtonItem() {
notificationsButtonCancellable = nil
if isNotificationsBarButtonEnabled && traitCollection.horizontalSizeClass == .regular {
notificationsButtonCancellable = notificationsButtonViewModel.$image.sink { [weak self] in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespaces here too.

@kean kean enabled auto-merge December 11, 2024 13:53
@kean kean disabled auto-merge December 11, 2024 14:16
@kean kean enabled auto-merge December 11, 2024 14:18
@kean kean added this pull request to the merge queue Dec 11, 2024
Merged via the queue into trunk with commit 9e972b6 Dec 11, 2024
25 checks passed
@kean kean deleted the task/enable-quick-access-to-notifications branch December 11, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazytonyli crazytonyli crazytonyli approved these changes

Assignees
No one assigned
Labels
Reader
Projects
None yet
Milestone
25.6 ❄️
Development

Successfully merging this pull request may close these issues.

iPad: Notifications bell appears only on Home
4 participants
@kean @dangermattic @wpmobilebot @crazytonyli