Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Navigate to post stats from authors stats #23761

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Nov 4, 2024

Simplify viewing stats for a particular author's individual posts by allowing navigation from within the "view more" list.

Relates to:

To test:

Screen recording

navigate-to-post-stats-from-authors-stats.MP4

  1. Navigate to Stats.
  2. Scroll down to the Authors section.
  3. Tap View more.
  4. Tap to expand an author row.
  5. Tap to navigate to one of the author's posts.

Regression Notes

  1. Potential unintended areas of impact
    Collapsible table rows in Stats.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested surround Stats tables.
  3. What automated tests I added (or what prevented me from doing so)
    None, I deemed it low priority for this small feature addition.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

Simplify viewing stats for a particular author's individual posts.
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 4, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 4, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23761-a3052af
Version25.4.2
Bundle IDorg.wordpress.alpha
Commita3052af
App Center BuildWPiOS - One-Offs #10990
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 4, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23761-a3052af
Version25.4.2
Bundle IDcom.jetpack.alpha
Commita3052af
App Center Buildjetpack-installable-builds #10030
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@dcalhoun dcalhoun marked this pull request as ready for review November 4, 2024 20:27
@dcalhoun
Copy link
Member Author

dcalhoun commented Nov 4, 2024

@kean I noted a collapsible section's caret icon (^) is animated when toggled in the top-level Stats screen, but there is no animation when toggled in the nested "view more" screen. This issue already exists in the trunk branch, so it appears unrelated to these changes. I'm curious though—any ideas as to why the animation is missing in only one context?

Screen recording: animation comparison

expanding-animation.mp4

@dcalhoun dcalhoun requested a review from kean November 4, 2024 20:27
@kean
Copy link
Contributor

kean commented Nov 5, 2024

Tap View more.

Ah, that's what I missed last time.

any ideas as to why the animation is missing in only one context?

Not sure as they seem to use the same views for cells. I think it looks better with no animation.

Btw, it also doesn't match the iOS system design. It uses "chevron.right" for the collapsed and "chevron.down" for the expanded state.

Screenshot 2024-11-05 at 9 58 45 AM

@dcalhoun dcalhoun added this pull request to the merge queue Nov 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 5, 2024
@dcalhoun dcalhoun enabled auto-merge November 5, 2024 16:06
@dcalhoun dcalhoun added this pull request to the merge queue Nov 5, 2024
Merged via the queue into trunk with commit 9a23848 Nov 5, 2024
24 checks passed
@dcalhoun dcalhoun deleted the feat/navigate-to-post-stats-from-authors-stats branch November 5, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants