-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up Gravatar to 2.0.0 #23320
Bump up Gravatar to 2.0.0 #23320
Conversation
…s way Gravatar SDK and the WP app can use the same records
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing together with Automattic/Gravatar-SDK-iOS#276 , things look good to me.
I'd say It's ready to move to formal review 👍
WordPress/Classes/ViewRelated/Gravatar/UIImageView+Gravatar.swift
Outdated
Show resolved
Hide resolved
Ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
# Conflicts: # Podfile.lock
Fixes #
Gravatar SDK has a new release(yaay 🎉 ). This PR makes necessary updates to use it.
To test:
Smoke test scenarios in #22543. The avatars should load fine. Uploading a new avatar should also work fine.
Regression Notes
All avatars in the app.
I documented the use cases in #22543 and tested those.
No new automated tests were added since we aren't adding new functionality.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: