Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up Gravatar to 2.0.0 #23320

Merged
merged 7 commits into from
Jun 12, 2024
Merged

Bump up Gravatar to 2.0.0 #23320

merged 7 commits into from
Jun 12, 2024

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Jun 6, 2024

Fixes #

Gravatar SDK has a new release(yaay 🎉 ). This PR makes necessary updates to use it.

To test:

Smoke test scenarios in #22543. The avatars should load fine. Uploading a new avatar should also work fine.

Regression Notes

  1. Potential unintended areas of impact

All avatars in the app.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

I documented the use cases in #22543 and tested those.

  1. What automated tests I added (or what prevented me from doing so)

No new automated tests were added since we aren't adding new functionality.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@pinarol pinarol added this to the 25.2 milestone Jun 6, 2024
@pinarol pinarol self-assigned this Jun 6, 2024
…s way Gravatar SDK and the WP app can use the same records
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 6, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23320-1a5edd1
Version25.1
Bundle IDorg.wordpress.alpha
Commit1a5edd1
App Center BuildWPiOS - One-Offs #10151
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 6, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23320-1a5edd1
Version25.1
Bundle IDcom.jetpack.alpha
Commit1a5edd1
App Center Buildjetpack-installable-builds #9199
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing together with Automattic/Gravatar-SDK-iOS#276 , things look good to me.
I'd say It's ready to move to formal review 👍

@pinarol pinarol marked this pull request as ready for review June 10, 2024 11:10
@pinarol pinarol requested a review from etoledom June 10, 2024 11:10
@pinarol
Copy link
Contributor Author

pinarol commented Jun 10, 2024

Ready to review.

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pinarol pinarol merged commit 7074639 into trunk Jun 12, 2024
24 checks passed
@pinarol pinarol deleted the wppinar/gravatar-update branch June 12, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants