In-App Updates: Show notice (flexible) or modal (blocking)

[momo-ozawa]

Part of https://github.com/Automattic/wordpress-mobile/issues/55
Part of https://github.com/Automattic/wordpress-mobile/issues/56

Description

• Adds preliminary UI for flexible and blocking updates
  • 🚧 Design will be refined later
  • 🚧 The "Update" CTA doesn't do anything yet; it'll be addressed in a future PR
• On app launch, checks if any updates are available
  • Shows a modal if there's a blocking update available
  • Shows a notice if there's a flexible update available

How to test

Flexible update

Precondition: On Xcode, change the app version to something lower than the current app store version

• Build and run the app
• Verify the "App Update Available" notice is displayed

Blocking update

Precondition: On Xcode, change the app version to something lower than the current app store version

• Build and run the app
• Change the in app update remote config value to the current app store version
• Verify the "App Update Available" modal is displayed

Minimum OS version

Precondition: On Xcode, change the app version to something lower than the current app store version

• Change InAppCoordinator.swift L62 to "14.0"
• Build and run the app
• Verify no notice or modal is displayed

Regression Notes

1. Potential unintended areas of impact

2. What I did to test those areas of impact (or what existing automated tests I relied on)

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23195-89e1488
	Version	24.9
	Bundle ID	org.wordpress.alpha
	Commit	89e1488
	App Center Build	WPiOS - One-Offs #9931

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23195-89e1488
	Version	24.9
	Bundle ID	com.jetpack.alpha
	Commit	89e1488
	App Center Build	jetpack-installable-builds #8980

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[kean]

It looks like it's identical to QuickStartNoticeStyle.

[momo-ozawa]

It is, but I wasn't sure if I'd want to extend it when I implement showing a dismissed notice again after a certain interval. If I don't end up doing that, I'll get rid of it.

[dangermattic]

	1 Warning
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

[momo-ozawa]

Hey @kean, can you re-review this PR? Thanks! 🙇‍♀️

[kean]

I tested both of the scenarios. The UI did show up + I tested blocking updates and accessibility features.

Feedback:

• (Nit) the button alignment the snackbar is a bit odd. I'd suggest centering them.
• Should there be a feature flag?
• (Noting) The app performs the check on every launch. Ideally, it should only check it once in a while and only if there popup can be shown (based on the business logic – time interval, number of attempts, etc)
• (Note) "Update" button doesn't work, which seems expected based on the TODOs in the code
• I suggest using https://github.com/apple/swift-package-manager/blob/main/Sources/PackageDescription/Version.swift for version parsing and comparison. It supports pre-release identifiers and a couple of other things. It will be a valuable addition to the app.

[momo-ozawa]

@kean, thanks for the feedback!

(Nit) the button alignment the snackbar is a bit odd. I'd suggest centering them.

I'll look into this later!

Should there be a feature flag?

Yes - #23202 (thanks for approving 🙇‍♀️)

(Noting) The app performs the check on every launch. Ideally, it should only check it once in a while and only if there popup can be shown (based on the business logic – time interval, number of attempts, etc)
(Note) "Update" button doesn't work, which seems expected based on the TODOs in the code

These will be addressed in a separate PR :)

I suggest using https://github.com/apple/swift-package-manager/blob/main/Sources/PackageDescription/Version.swift for version parsing and comparison. It supports pre-release identifiers and a couple of other things. It will be a valuable addition to the app.

Good shout. Will address this in a future PR