Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Settings: Minor UI tweaks #23164

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

kean
Copy link
Contributor

@kean kean commented May 6, 2024

(This is a suggestion / not based on any project)

  • Reduce the number of sections and align more closely with Gutenberg/Android
  • Fix an issue with phantom before "More Options" due to an empty "Share" section

Here's before and after:

Screenshot 2024-05-06 at 11 34 53 AM Screenshot 2024-05-06 at 12 09 07 PM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean requested a review from momo-ozawa May 6, 2024 16:11
@kean kean added this to the 24.9 milestone May 6, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 6, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23164-b4fb3a3
Version24.8
Bundle IDorg.wordpress.alpha
Commitb4fb3a3
App Center BuildWPiOS - One-Offs #9819
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 6, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23164-b4fb3a3
Version24.8
Bundle IDcom.jetpack.alpha
Commitb4fb3a3
App Center Buildjetpack-installable-builds #8867
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean changed the title Post Settings: minor UI tweaks Post Settings: Minor UI tweaks May 6, 2024
@kean kean force-pushed the task/add-actions-to-post-settings branch from badd1a5 to b4fb3a3 Compare May 7, 2024 12:18
@kean
Copy link
Contributor Author

kean commented May 7, 2024

Hey, I reverted the change to "sticky" – not sure it belongs to the top section.
I should've probably been more patient and waited until the redesign ... but I think these changes are fairly straightforward just to address the main inconsistencies with Gutenberg and Android.

@kean kean merged commit 86dcc60 into trunk May 7, 2024
24 checks passed
@kean kean deleted the task/add-actions-to-post-settings branch May 7, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants