Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Post Editor context menu to use new style and update copy #23145

Merged
merged 6 commits into from
May 7, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented May 2, 2024

Fixes #11994:

  • Update the "More" menu in the editor to use the modern iOS look (easier to reach, can be used with a single gesture, has images to make it easier to find what you need)
  • Update some copy to match Gutenberg (they should not invent its own undocumented terminology):
    • "Switch to HTML Mode" → "Code Editor"
    • "Switch to Visual Mode" → "Visual Editor"
    • "History" → "Revisions (%i)"
  • Update the copy in the "Revisions" screen to replace "History" with "Revisions"
  • Update table view style in the "Revisions" screen to "insetGrouped".
new-context-menu-2 Screenshot 2024-05-02 at 6 01 52 PM

To test:

  • ✅ Verify the changes according to the acceptance criteria listed in the description

Known Issues

  • ⚠️ "Content Structure" is not immediately available – seems to be an existing issue

Regression Notes

  1. Potential unintended areas of impact: Post Editor
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 24.9 milestone May 2, 2024
@kean kean requested a review from momo-ozawa May 2, 2024 22:07
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 2, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23145-54b6b93
Version24.8
Bundle IDorg.wordpress.alpha
Commit54b6b93
App Center BuildWPiOS - One-Offs #9799
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 2, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23145-54b6b93
Version24.8
Bundle IDcom.jetpack.alpha
Commit54b6b93
App Center Buildjetpack-installable-builds #8845
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean force-pushed the task/editor-update-more-menu branch from 739a768 to 2fc8939 Compare May 2, 2024 22:24
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few nitpicks:

  • Can you remove the separator for the section header in the revisions screen?
  • Wdyt of using the same date format for the "post created on ..." footer?

@kean kean force-pushed the task/editor-update-more-menu branch from 2fc8939 to 68dd8e7 Compare May 4, 2024 15:37
@kean
Copy link
Contributor Author

kean commented May 4, 2024

Can you remove the separator for the section header in the revisions screen?

No idea how I missed it – fixed.

Wdyt of using the same date format for the "post created on ..." footer?

I updated the format to .medium and also removed it for drafts – as was discussed before, dateCreated doesn't mean what it's supposed to mean for drafts. Even on the screenshot you provided, it was incorrect.

Screenshot 2024-05-04 at 11 36 45 AM

@kean kean force-pushed the task/editor-update-more-menu branch from 68dd8e7 to 54b6b93 Compare May 4, 2024 17:11
@kean kean merged commit cd5d37f into trunk May 7, 2024
23 of 24 checks passed
@kean kean deleted the task/editor-update-more-menu branch May 7, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "Revision Browser" entry in the editor "..." menu
3 participants