Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ParentPageSettingsViewController to PostSettingsViewController #23136

Merged
merged 2 commits into from
May 2, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented May 1, 2024

Fixes #13150

There are multiple pros to this approach:

  • You can now create a new page, set a parent, and publish it without ever closing the editor
  • Cleaner context menu with fewer rarely used actions (I'd fully remove "Page Attributes" if there is time)
  • Much simpler implementation with one less entry point for syncing: we now simply use the existing code from PostSettingsViewController

To test:

Follow these steps to change the parent page:

Screen.Recording.2024-05-01.at.4.15.05.PM.mov
  • ✅ Verify that the "Set parent" context menu action was removed from the context menu in the post list

Regression Notes

  1. Potential unintended areas of impact: Page Settings

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 24.9 milestone May 1, 2024
@kean kean requested a review from momo-ozawa May 1, 2024 20:22
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23136-bc6d84e
Version24.8
Bundle IDorg.wordpress.alpha
Commitbc6d84e
App Center BuildWPiOS - One-Offs #9760
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23136-bc6d84e
Version24.8
Bundle IDcom.jetpack.alpha
Commitbc6d84e
App Center Buildjetpack-installable-builds #8806
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described

@kean kean merged commit 720047e into trunk May 2, 2024
25 checks passed
@kean kean deleted the task/move-parent-page-to-settings branch May 2, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to set parent to Page Settings in editor
3 participants