Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hack Week] Post success view #23128

Merged
merged 10 commits into from
May 2, 2024
Merged

[Hack Week] Post success view #23128

merged 10 commits into from
May 2, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Apr 30, 2024 •
edited
Loading

Fixes ##21509.

I've been going through the maintenance board, noticed the linked defect, and decided to resurrect this PR from the last Hack Week, which I didn't get to complete then. The new screen looks more like what you see in Gutenberg, and has a new "Promote with Blaze" button.

The initial idea was to show this automatically as part of the Prepublishing sheet, but this is a more conservative approach that simply replaced the current screen (with a slightly broken layout).

The design comes from one of the prototypes made with Chris, but with some minor changes. There've been so many versions of this, I don't any particular direction was picked as the final one in the end.

To test:

  • Publish a new post
  • Tap "View" on a snackbar
  • ✅ Verify that the updated success screen is shown
  • ✅ Verify that all buttons are working
  • ✅ Verify that for Blaze-enabled blogs, "Promote with Blaze" button is visible.

Regression Notes

  1. Potential unintended areas of impact: Post Publish Success Notice View
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

dangermattic commented Apr 30, 2024 •
edited
Loading

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@kean kean force-pushed the task/new-post-success-view branch from 85b14ff to aa65433 Compare April 30, 2024 19:56
kean
kean commented Apr 30, 2024
View reviewed changes
Podfile.lock Outdated
@@ -197,7 +197,7 @@ SPEC CHECKSUMS:
Gifu: 416d4e38c4c2fed012f019e0a1d3ffcb58e5b842
Gravatar: 51437de6811c1d8d6f60c52985f2ca00a85cfc8e
Gridicons: 4455b9f366960121430e45997e32112ae49ffe1d
Gutenberg: 3117b6fe578fb7f0bb75377ba96f436ee05c30fe
Gutenberg: cd6259542b7078fe875d51b21c962d02bac6c032
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it was added – will investigate tomorrow. When I run pod install in trunk it also changes the Podfile.lock.

WordPress/Classes/Utility/Analytics/WPAnalyticsEvent.swift Outdated
@@ -1595,7 +1595,7 @@ import Foundation
case .assertionFailure:
return "assertion_failure"
case .postCoordinatorErrorEncountered:
return "post-coordinator-eerror-encountered"
return "post-coordinator-error-encountered"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found this typo during testing.

@kean kean requested a review from momo-ozawa April 30, 2024 19:57
@kean kean added this to the 24.9 milestone Apr 30, 2024
momo-ozawa
momo-ozawa reviewed May 1, 2024
View reviewed changes
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as described, but I have some design questions

  • Would it make more sense to group the CTAs together? (i.e. Share, Promote with Blaze, Done are all full width buttons vertically stacked)
  • Is there a way we can avoid truncating "View on url..."?

momo-ozawa
momo-ozawa reviewed May 1, 2024
View reviewed changes
WordPress/Resources/AppImages.xcassets/post-published.imageset/post-publihsed.svg Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] typo in filename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@kean
Copy link
Contributor Author

kean commented May 1, 2024

Hey, I updated the design based on what we discussed.

Screenshot 2024-05-01 at 11 23 42 AM

@kean kean requested a review from momo-ozawa May 1, 2024 15:25
@kean kean mentioned this pull request May 1, 2024
Closed
momo-ozawa
momo-ozawa approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did you figure out the Podfile.lock issue?

@kean kean force-pushed the task/new-post-success-view branch from ae81b80 to 3ea1022 Compare May 2, 2024 11:27
@kean
Copy link
Contributor Author

kean commented May 2, 2024

LGTM! Did you figure out the Podfile.lock issue?

Looks like it got updated in trunk. The change disappear after the rebase.

@kean kean enabled auto-merge May 2, 2024 11:31
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 2, 2024 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23128-0dc1695
Version24.8
Bundle IDorg.wordpress.alpha
Commit0dc1695
App Center BuildWPiOS - One-Offs #9768
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 2, 2024 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23128-0dc1695
Version24.8
Bundle IDcom.jetpack.alpha
Commit0dc1695
App Center Buildjetpack-installable-builds #8814
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean force-pushed the task/new-post-success-view branch from 3ea1022 to 0dc1695 Compare May 2, 2024 17:20
@kean kean requested a review from a team as a code owner May 2, 2024 17:20
@kean kean merged commit 5ad4303 into trunk May 2, 2024
23 of 24 checks passed
@kean kean deleted the task/new-post-success-view branch May 2, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momo-ozawa momo-ozawa momo-ozawa approved these changes

Assignees
No one assigned
Labels
[Type] Task
Projects
None yet
Milestone
24.9
Development

Successfully merging this pull request may close these issues.
4 participants
@kean @dangermattic @wpmobilebot @momo-ozawa