Offline Mode: Switch to local feature flag #23105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23105-6c81ca8 | |
| Version | 24.7 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 6c81ca8 | |
| App Center Build | WPiOS - One-Offs #9712 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23105-6c81ca8 | |
| Version | 24.7 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 6c81ca8 | |
| App Center Build | jetpack-installable-builds #8756 |
kean
reviewed
Apr 26, 2024
| /// If the feature flag hasn't been assigned to a rollout group yet, assigns the flag to a group. | ||
| /// | ||
| private func rolloutGroup(for featureFlag: RolloutConfigurableFlag) -> Int { | ||
| let key = key(for: featureFlag) |
There was a problem hiding this comment.
There is no need to assign more than one group (one per flag). The same group assignment can be used for all flags. If there is only one group key, it might also be beneficial to cache it in memory for further invocations.
| /// To set a percentage rollout, return a value between 1 and 100 inclusive. | ||
| /// If a percentage rollout isn't applicable for the flag, return nil. | ||
| /// | ||
| var rolloutPercentage: Int? { |
There was a problem hiding this comment.
(Suggestion) I would suggest modeling it using floats 0.0...<1.0 to allow more granularity.
|
Hi @momo-ozawa 👋 , I'm bumping this PR's milestone to |
kean
approved these changes
Apr 29, 2024
|
Thanks @dvdchr, I've merged this into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
syncPublishingflag to a local feature flagFeatureFlagRolloutStoreto facilitate rolling out the flag to a specified percentage of usersHow to test
FeatureFlag.swiftL45 toreturn FeatureFlagRolloutStore().isRolloutEnabled(for: self)in order to test the percentage rollout mechanismFeatureFlagRolloutStore.swiftsyncPublishingrollout percentage set to 1%syncPublishingrollout percentage set to a value higher thanassigned rollout group / 10(e.g. if the assigned group was 120, set the rollout percentage to 13)Regression Notes
Potential unintended areas of impact
sync publishing feature flag
What I did to test those areas of impact (or what existing automated tests I relied on)
tested manually
What automated tests I added (or what prevented me from doing so)
none
PR submission checklist:
RELEASE-NOTES.txtif necessary.