Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update page context menu with Stats and Settings #23065

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Apr 23, 2024

  • Make "Settings" more discoverable by moving it from a submenu to a separate section and make it available for unpublished posts
  • Add "Stats" to the same section to match "Posts"
  • Update the stats icon – open to suggestions but it just has to be non-filled like the rest of the icons 😅

Note: "Page Attributes" should ideally be moved to the "Settings" page.

Screenshot 2024-04-23 at 8 30 28 AM

Regression Notes

  1. Potential unintended areas of impact: Page Context Menu
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the Pending milestone Apr 23, 2024
@kean kean requested a review from momo-ozawa April 23, 2024 12:30
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 23, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23065-534ffff
Version24.7
Bundle IDcom.jetpack.alpha
Commit534ffff
App Center Buildjetpack-installable-builds #8656
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 23, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23065-534ffff
Version24.7
Bundle IDorg.wordpress.alpha
Commit534ffff
App Center BuildWPiOS - One-Offs #9613
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kean kean enabled auto-merge April 23, 2024 16:04
@kean kean merged commit e79ee20 into trunk Apr 23, 2024
23 of 24 checks passed
@kean kean deleted the task/page-settings-more-discoverable branch April 23, 2024 16:18
dvdchr added a commit that referenced this pull request Apr 29, 2024
I've tested that the Stats context menu item does not appear in
the WordPress app.

See: #23065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants