Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Reachability from 3.2 to 3.7.6 #23030

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Update Reachability from 3.2 to 3.7.6 #23030

merged 4 commits into from
Apr 24, 2024

Conversation

crazytonyli
Copy link
Contributor

The latest version has a privacy manifest file, which we need. Here are the full changes, which aren't a lot.

@crazytonyli crazytonyli added this to the 24.8 milestone Apr 18, 2024
@crazytonyli crazytonyli requested a review from mokagio April 18, 2024 02:07
@crazytonyli crazytonyli self-assigned this Apr 18, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 18, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23030-0c5ce64
Version24.7
Bundle IDorg.wordpress.alpha
Commit0c5ce64
App Center BuildWPiOS - One-Offs #9620
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 18, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23030-0c5ce64
Version24.7
Bundle IDcom.jetpack.alpha
Commit0c5ce64
App Center Buildjetpack-installable-builds #8664
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@crazytonyli crazytonyli enabled auto-merge April 19, 2024 01:20
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shared_with_networking_pods name of that method made me think this was a transitive dependency, and I was hoping we could remove it from the Podfile and let it be inherited. Alas, Podfile.lock shows it's a top level depedency.

All good 👍

@crazytonyli crazytonyli merged commit 9d75b23 into trunk Apr 24, 2024
24 checks passed
@crazytonyli crazytonyli deleted the update-reachability branch April 24, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants