Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gravatar] Rename types to ImageCache and ImageCaching #22663

Conversation

andrewdmontgomery
Copy link
Contributor

@andrewdmontgomery andrewdmontgomery commented Feb 21, 2024

Fixes part of #22543

To test:

Regression Notes

Checkout Gravatar branch: Automattic/Gravatar-SDK-iOS#50
Checkout WordPressUI branch: wordpress-mobile/WordPressUI-iOS#146

Follow the steps mentioned here: #22543 (comment)

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

Sorry, something went wrong.

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewdmontgomery
Copy link
Contributor Author

Checkout: https://github.com/wordpress-mobile/WordPressUI-iOS/pull/146/files#r1500335800

These changes might not be needed 👍

True! I'm testing this now using our gravatar-integration branch of WPiOS.

@andrewdmontgomery
Copy link
Contributor Author

It compiles and runs! I'll close this PR and branch, and update the wordpress-mobile/WordPressUI-iOS#146 with testing notes

@andrewdmontgomery andrewdmontgomery deleted the andrewdmontgomery/rename-ImageCaching branch February 26, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants