[Gutenberg] Add error boundary components and exception logging #22655
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -169,6 +169,13 @@ | |
| dsym_path: lane_context[SharedValues::DSYM_OUTPUT_PATH] | ||
| ) | ||
|
|
||
| upload_gutenberg_sourcemaps( | ||
| sentry_project_slug: SENTRY_PROJECT_SLUG_WORDPRESS, | ||
| release_version: release_version_current, | ||
| build_version: build_code_current, | ||
| app_identifier: WORDPRESS_BUNDLE_IDENTIFIER | ||
| ) | ||
|
Comment on lines
+172
to
+177
There was a problem hiding this comment. This source map will be used for the App Store builds (beta and production) of the WordPress app. |
||
|
|
||
| next unless options[:create_release] | ||
|
|
||
| archive_zip_path = File.join(PROJECT_ROOT_FOLDER, 'WordPress.xarchive.zip') | ||
|
|
@@ -217,6 +224,13 @@ | |
| project_slug: SENTRY_PROJECT_SLUG_JETPACK, | ||
| dsym_path: lane_context[SharedValues::DSYM_OUTPUT_PATH] | ||
| ) | ||
|
|
||
| upload_gutenberg_sourcemaps( | ||
| sentry_project_slug: SENTRY_PROJECT_SLUG_JETPACK, | ||
| release_version: release_version_current, | ||
| build_version: build_code_current, | ||
| app_identifier: JETPACK_BUNDLE_IDENTIFIER | ||
| ) | ||
|
Comment on lines
+228
to
+233
There was a problem hiding this comment. This source map will be used for the App Store builds (beta and production) of the Jetpack app. |
||
| end | ||
|
|
||
| # Builds the "WordPress Internal" app and uploads it to App Center | ||
|
|
@@ -266,6 +280,14 @@ | |
| project_slug: SENTRY_PROJECT_SLUG_WORDPRESS, | ||
| dsym_path: lane_context[SharedValues::DSYM_OUTPUT_PATH] | ||
| ) | ||
|
|
||
| upload_gutenberg_sourcemaps( | ||
| sentry_project_slug: SENTRY_PROJECT_SLUG_WORDPRESS, | ||
| release_version: release_version_current_internal, | ||
| build_version: build_code_current_internal, | ||
| app_identifier: 'org.wordpress.internal' | ||
| ) | ||
|
Comment on lines
+284
to
+289
There was a problem hiding this comment. This source map will be used for the internal builds of the WordPress app. As far as I checked, this version is seems no longer used. |
||
|
|
||
fluiddot marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| end | ||
|
|
||
| # Builds the WordPress app for a Prototype Build ("WordPress Alpha" scheme), and uploads it to App Center | ||
|
|
@@ -283,7 +305,8 @@ | |
| output_app_name: 'WordPress Alpha', | ||
| appcenter_app_name: 'WPiOS-One-Offs', | ||
| app_icon: ':wordpress:', # Use Buildkite emoji | ||
| sentry_project_slug: SENTRY_PROJECT_SLUG_WORDPRESS, | ||
| app_identifier: 'org.wordpress.alpha' | ||
| ) | ||
| end | ||
|
|
||
|
|
@@ -302,7 +325,8 @@ | |
| output_app_name: 'Jetpack Alpha', | ||
| appcenter_app_name: 'jetpack-installable-builds', | ||
| app_icon: ':jetpack:', # Use Buildkite emoji | ||
| sentry_project_slug: SENTRY_PROJECT_SLUG_JETPACK, | ||
| app_identifier: 'com.jetpack.alpha' | ||
| ) | ||
| end | ||
|
|
||
|
|
@@ -334,7 +358,8 @@ def generate_prototype_build_number | |
| # Builds a Prototype Build for WordPress or Jetpack, then uploads it to App Center and comment with a link to it on the PR. | ||
| # | ||
| # rubocop:disable Metrics/AbcSize | ||
| # rubocop:disable Metrics/ParameterLists | ||
| def build_and_upload_prototype_build(scheme:, output_app_name:, appcenter_app_name:, app_icon:, sentry_project_slug:, app_identifier:) | ||
| configuration = 'Release-Alpha' | ||
|
|
||
| # Get the current build version, and update it if needed | ||
|
|
@@ -385,6 +410,13 @@ def build_and_upload_prototype_build(scheme:, output_app_name:, appcenter_app_na | |
| dsym_path: lane_context[SharedValues::DSYM_OUTPUT_PATH] | ||
| ) | ||
|
|
||
| upload_gutenberg_sourcemaps( | ||
| sentry_project_slug:, | ||
| release_version: release_version_current, | ||
| build_version: build_number, | ||
| app_identifier: | ||
| ) | ||
|
|
||
| # Post PR Comment | ||
| comment_body = prototype_build_details_comment( | ||
| app_display_name: output_app_name, | ||
|
|
@@ -464,4 +496,41 @@ def upload_build_to_app_center( | |
| notify_testers: false | ||
| ) | ||
| end | ||
|
|
||
| def upload_gutenberg_sourcemaps(sentry_project_slug:, release_version:, build_version:, app_identifier:) | ||
| # The bundle and source map files are the same for all architectures. | ||
| gutenberg_bundle = File.join(PROJECT_ROOT_FOLDER, 'Pods/Gutenberg/Frameworks/Gutenberg.xcframework/ios-arm64/Gutenberg.framework') | ||
|
|
||
| Dir.mktmpdir do |sourcemaps_folder| | ||
| # It's important that the bundle and source map files have specific names, otherwise, Sentry | ||
| # won't symbolicate the stack traces. | ||
| FileUtils.cp(File.join(gutenberg_bundle, 'App.js'), File.join(sourcemaps_folder, 'main.jsbundle')) | ||
| FileUtils.cp(File.join(gutenberg_bundle, 'App.composed.js.map'), File.join(sourcemaps_folder, 'main.jsbundle.map')) | ||
|
|
||
| # To generate the full release version string to attach the source maps, we need to specify: | ||
| # - App identifier | ||
| # - Release version | ||
| # - Build version | ||
| # This conforms to the following format: <app_identifier>@<release_version>+<build_version> | ||
| # Here are a couple of examples: | ||
| # - Prototype build: [email protected]+pr22654-07765b3 | ||
| # - App Store build: [email protected]+24.1.0.3 | ||
|
|
||
| sentry_upload_sourcemap( | ||
| auth_token: get_required_env('SENTRY_AUTH_TOKEN'), | ||
| org_slug: SENTRY_ORG_SLUG, | ||
| project_slug: sentry_project_slug, | ||
| version: release_version, | ||
| dist: build_version, | ||
| build: build_version, | ||
| app_identifier:, | ||
| # When the React native bundle is generated, the source map file references | ||
| # include the local machine path, with the `rewrite` and `strip_common_prefix` | ||
| # options Sentry automatically strips this part. | ||
| rewrite: true, | ||
| strip_common_prefix: true, | ||
| sourcemap: sourcemaps_folder | ||
| ) | ||
| end | ||
| end | ||
| end | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing a production version of the JS bundle in local builds, I noticed we don't have a quick way to use a local bundle. For this reason, I added a third option to fetch the bundle by pointing to a local path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The option to fetch the bundle form
$PODS_ROOT/Gutenberg/bundle/iosseems to be deprecated as the library is provided with the XCFramework. We could remove it.