Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Monitoring: Add site monitoring menu item #22475

Merged
merged 6 commits into from
Jan 26, 2024

Conversation

momo-ozawa
Copy link
Contributor

Fixes #22458

Description

Adds a site monitoring menu item to the maintenance section

Note

  • Currently investigating the conditions to show the site monitoring option by comparing it to Calypso - any updates to the logic will be addressed in a future PR (Slack ref: p1706193407099459/1706106120.703839-slack-C06EFHCP0PN)
  • The Site Monitoring screen is a skeleton view for now - this will be updated in a future PR

How to test

  • Enable the site monitoring feature flag
  • Switch to an atomic site
  • Go to the more menu
  • Verify the Site Monitoring menu is shown

Regression Notes

  1. Potential unintended areas of impact
    BlogDetailsVC

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 25, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22475-16afe0e
Version24.1
Bundle IDcom.jetpack.alpha
Commit16afe0e
App Center Buildjetpack-installable-builds #7583
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 25, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22475-16afe0e
Version24.1
Bundle IDorg.wordpress.alpha
Commit16afe0e
App Center BuildWPiOS - One-Offs #8556
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

extension BlogDetailsViewController {

@objc func shouldShowSiteMonitoring() -> Bool {
RemoteFeatureFlag.siteMonitoring.enabled() && blog.isAdmin && blog.isAtomic()
Copy link
Contributor

@kean kean Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move it to - (BOOL)supports:(BlogFeature)feature defined on Biog like the other features.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@kean kean self-requested a review January 25, 2024 21:25
@momo-ozawa momo-ozawa enabled auto-merge January 26, 2024 10:04
@momo-ozawa momo-ozawa merged commit 963d9e0 into trunk Jan 26, 2024
22 checks passed
@momo-ozawa momo-ozawa deleted the task/22458-site-monitoring-menu-item branch January 26, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site Monitoring: Add Monitoring tools section in site menu
3 participants