-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Google domains promotional card from the dashboard #22216
Conversation
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
Will we not remove the |
@alpavanoglu We should, yes. I'd prefer us not to do it straight away though, just to be safe. I'm preparing a draft PR now that removes the unneeded code and also refactors |
@hassaanelgarem sounds good. I think we can open/merge the follow up PR whenever it is ready as if in time, we need the card again, we can find it through the git history. It doesn't really vanish after all if that's what you have meant. |
case .domainFocus: | ||
return true | ||
case .googleDomainsCard: | ||
return false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional:
I think we could add a comment here saying that the functionality will be removed with a follow up pr and/or link the draft PR. If you think that it isn't necessary as you are already working on it, that's also fine.
After merging from |
Description
This PR disables the Google domains card in the dashboard.
Testing Instructions
Regression Notes
N/A
N/A
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.