Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt Gutenberg workaround when not running locally #22035

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Nov 13, 2023

A quick followup to #21961 – Not sure how it worked before this change, given that the code called in the post_integrate was defined after the private directive 🤔

Anyways, this should set things straight and avoid unnecessary loops.

For context: I noticed this because I my project file was all messed up with no Gutenberg framework and I went to look into my Podfile settings. I didn't found the cause for my project file issue, but noticed this.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 13, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22035-0fb7e02
Version23.7
Bundle IDorg.wordpress.alpha
Commit0fb7e02
App Center BuildWPiOS - One-Offs #7876
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 13, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22035-0fb7e02
Version23.7
Bundle IDcom.jetpack.alpha
Commit0fb7e02
App Center Buildjetpack-installable-builds #6900
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio mokagio requested review from dcalhoun and twstokes November 13, 2023 09:13
@mokagio mokagio added the Tooling Build, Release, and Validation Tools label Nov 13, 2023
@mokagio mokagio added this to the 23.8 milestone Nov 13, 2023
@mokagio mokagio marked this pull request as ready for review November 13, 2023 09:14
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified both bundle exec pod install and LOCAL_GUTENBERG=1 bundle exec pod install succeed, and subsequent builds succeeded. 🚀

@mokagio mokagio force-pushed the mokagio/fix-cocoapods-setup branch from e7644d3 to 0fb7e02 Compare November 19, 2023 22:46
@mokagio mokagio enabled auto-merge November 19, 2023 22:46
@mokagio mokagio merged commit a63d8df into trunk Nov 19, 2023
21 of 23 checks passed
@mokagio mokagio deleted the mokagio/fix-cocoapods-setup branch November 19, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling Build, Release, and Validation Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants