Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with scheduling of posts not working on iOS 17 with Xcode 15 #22012

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Nov 9, 2023

Fixes #21649

I removed PartScreenPresentationController because it was used only in one place, which is a good thing because it means no other parts of the app has this regression. There is a way to implement the same (or better) behavior using the new-ish native UISheetPresentationController. But I decided to err on the side of simplicity and show it as a simple default model screen.

To test:

  • Follow the steps from the defect (requires Xcode 15!)
  • Verify that changing the scheduled date for an outstanding scheduled post works
Simulator.Screen.Recording.-.iPhone.15.-.2023-11-09.at.07.59.16.mp4

Regression Notes

  1. Potential unintended areas of impact: Scheduling Post
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the [Type] Bug label Nov 9, 2023
@kean kean requested a review from mokagio November 9, 2023 13:02
@kean kean added this to the Pending milestone Nov 9, 2023
@kean kean force-pushed the fix/scheduling-not-working branch from d5f1479 to 4ae88ed Compare November 9, 2023 13:03
@kean kean force-pushed the fix/scheduling-not-working branch from 4ae88ed to f6f066f Compare November 9, 2023 13:06
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 9, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22012-97a612f
Version23.7
Bundle IDorg.wordpress.alpha
Commit97a612f
App Center BuildWPiOS - One-Offs #7884
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 9, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22012-97a612f
Version23.7
Bundle IDcom.jetpack.alpha
Commit97a612f
App Center Buildjetpack-installable-builds #6908
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean requested a review from momo-ozawa November 20, 2023 01:28
@kean kean enabled auto-merge November 20, 2023 13:06
@kean kean merged commit 0b521e9 into trunk Nov 20, 2023
23 checks passed
@kean kean deleted the fix/scheduling-not-working branch November 20, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduling a post doesn't work in iOS 17 / Xcode 15
3 participants