Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts & Pages: Enable long press in search results #21967

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Nov 3, 2023

To test:

  • Open Posts/Pages
  • Verify that context menus open and test some of the actions (if one works, so should the others)
  • Open search
  • Verify that the same content menus open on long press

Regression Notes

  1. Potential unintended areas of impact: Posts & Pages search
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • [x ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 3, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21967-ad9672b
Version23.6
Bundle IDorg.wordpress.alpha
Commitad9672b
App Center BuildWPiOS - One-Offs #7728
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 3, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21967-ad9672b
Version23.6
Bundle IDcom.jetpack.alpha
Commitad9672b
App Center Buildjetpack-installable-builds #6745
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described! I noticed the "posts page" / "home page" attributes don't get updated in search results.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-11-06.at.09.45.08.mp4

@kean kean mentioned this pull request Nov 6, 2023
27 tasks
@kean
Copy link
Contributor Author

kean commented Nov 6, 2023

Thanks, I added it to the defects list.

@kean kean force-pushed the task/add-context-menu-long-press-search branch from b6317e7 to 9355342 Compare November 6, 2023 22:18
@kean
Copy link
Contributor Author

kean commented Nov 6, 2023

FYI, I pushed a couple of changes. I was working on another fix, I couldn't get it to work, but I added a minor improvements I made here.

@wpmobilebot
Copy link
Contributor

1 Warning
⚠️ View files have been modified, but no screenshot is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@kean kean requested a review from momo-ozawa November 7, 2023 16:20
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements!

@kean kean merged commit 2ab2f62 into trunk Nov 8, 2023
23 checks passed
@kean kean deleted the task/add-context-menu-long-press-search branch November 8, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants