Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts & Pages: Search for all posts #21966

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

kean
Copy link
Contributor

@kean kean commented Nov 3, 2023

Fixes the comment #21953 (comment) by searching posts from everyone by default.

To test:

  • Login on a site with multiple users
  • Open Posts
  • Select filter "Me"
  • Open Search
  • Verify that search doesn't apply the filter and search all posts

Regression Notes

  1. Potential unintended areas of impact: Posts & Pages
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21966-8ba9b7e
Version23.6
Bundle IDorg.wordpress.alpha
Commit8ba9b7e
App Center BuildWPiOS - One-Offs #7689
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21966-8ba9b7e
Version23.6
Bundle IDcom.jetpack.alpha
Commit8ba9b7e
App Center Buildjetpack-installable-builds #6706
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean merged commit d5daf06 into trunk Nov 6, 2023
@kean kean deleted the task/show-everyone-posts-in-search branch November 6, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants