Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts & Pages: Add Settings context menu action #21965

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Nov 3, 2023

Add "Settings" context menu action

To test:

  • Select "Settings" from Post (or Pages) context menu
  • Verify that when you tap "Cancel", the changes settings are reset to the previous values
  • Verify that when you dismiss the settings interactively, the changes settings are reset to the previous values
  • Verify that when you tap "Done", the changes are saved after showing a spinner and temporarily disabling interactions
Simulator.Screen.Recording.-.iPhone.15.-.2023-11-03.at.11.13.56.mp4

Regression Notes

  1. Potential unintended areas of impact: Posts & Pages
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 3, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21965-d5de113
Version23.6
Bundle IDorg.wordpress.alpha
Commitd5de113
App Center BuildWPiOS - One-Offs #7724
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 3, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21965-d5de113
Version23.6
Bundle IDcom.jetpack.alpha
Commitd5de113
App Center Buildjetpack-installable-builds #6740
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

@kean kean force-pushed the task/add-context-menu-to-editor branch from f781d5b to 6364b50 Compare November 6, 2023 15:12
@kean kean enabled auto-merge November 6, 2023 15:13
@kean kean merged commit 5593490 into trunk Nov 6, 2023
23 checks passed
@kean kean deleted the task/add-context-menu-to-editor branch November 6, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants