Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts & Pages: Allow setting a posts page back to a regular page #21963

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

momo-ozawa
Copy link
Contributor

@momo-ozawa momo-ozawa commented Nov 3, 2023

Description

  • Adds an option for setting a posts page back to a regular page, to match behavior on Calypso
  • Fixes actions for a homepage (can't trash a homepage or move it to drafts)
Fix homepage actions Set post page as reg page

How to test

  • Go to the pages list screen
  • Verify that a homepage doesn't have the "move to draft" or "move to trash" options
  • Verify that a posts page has the "set as regular page" option
  • Verify that "set as regular page" works as expected

Regression Notes

  1. Potential unintended areas of impact
    pages context menu

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    PageMenuViewModelTests

  3. What automated tests I added (or what prevented me from doing so)
    see above

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@momo-ozawa momo-ozawa added this to the 23.7 milestone Nov 3, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 3, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21963-0bb5b5a
Version23.6
Bundle IDorg.wordpress.alpha
Commit0bb5b5a
App Center BuildWPiOS - One-Offs #7715
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 3, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21963-0bb5b5a
Version23.6
Bundle IDcom.jetpack.alpha
Commit0bb5b5a
App Center Buildjetpack-installable-builds #6731
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@momo-ozawa momo-ozawa force-pushed the task/posts-pages-set-regular-page branch from 1222189 to 366baa9 Compare November 3, 2023 14:54
@momo-ozawa momo-ozawa changed the title Posts & Pages: Allow setting a homepage or posts page back to a regular page Posts & Pages: Allow setting a posts page back to a regular page Nov 3, 2023
@momo-ozawa momo-ozawa requested a review from kean November 3, 2023 14:59
@momo-ozawa momo-ozawa force-pushed the task/posts-pages-set-regular-page branch from 366baa9 to 72b44d1 Compare November 3, 2023 15:07
@momo-ozawa momo-ozawa marked this pull request as ready for review November 3, 2023 15:07
@momo-ozawa momo-ozawa force-pushed the task/posts-pages-set-regular-page branch from 72b44d1 to 7da3f28 Compare November 3, 2023 15:09
@momo-ozawa momo-ozawa mentioned this pull request Nov 3, 2023
27 tasks
@momo-ozawa momo-ozawa enabled auto-merge November 3, 2023 15:43
@momo-ozawa momo-ozawa disabled auto-merge November 3, 2023 15:49
Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested – worked as expected.

# Conflicts:
#	WordPress/Classes/ViewRelated/Post/AbstractPostMenuHelper.swift
@momo-ozawa momo-ozawa enabled auto-merge November 6, 2023 11:00
@momo-ozawa momo-ozawa merged commit 3f1f1c3 into trunk Nov 6, 2023
21 of 23 checks passed
@momo-ozawa momo-ozawa deleted the task/posts-pages-set-regular-page branch November 6, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants