Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Posts & Pages: Minor fixes and improvements #21958

Merged
merged 9 commits into from
Nov 3, 2023
Merged

Posts & Pages: Minor fixes and improvements #21958

merged 9 commits into from
Nov 3, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Nov 2, 2023

Regression Notes

  1. Potential unintended areas of impact: Posts & Pages
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 23.7 milestone Nov 2, 2023
@kean kean requested a review from momo-ozawa November 2, 2023 18:33
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 2, 2023 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21958-1e701e2
Version23.6
Bundle IDorg.wordpress.alpha
Commit1e701e2
App Center BuildWPiOS - One-Offs #7681
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 2, 2023 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21958-1e701e2
Version23.6
Bundle IDcom.jetpack.alpha
Commit1e701e2
App Center Buildjetpack-installable-builds #6698
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean force-pushed the task/minor-fixes-posts-and-pages branch from b729cdc to a20ec03 Compare November 3, 2023 02:54
momo-ozawa
momo-ozawa reviewed Nov 3, 2023
View reviewed changes
WordPress/Classes/ViewRelated/Pages/PageListViewController+Menu.swift
@@ -91,11 +89,6 @@ extension PageListViewController: InteractivePostViewDelegate {
}

private func trashPage(_ page: Page) {
guard ReachabilityUtils.isInternetReachable() else {
ReachabilityUtils.showNoInternetConnectionNotice(message: Strings.offlineMessage)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the offline message string as well

momo-ozawa
momo-ozawa reviewed Nov 3, 2023
View reviewed changes
WordPress/Classes/ViewRelated/Pages/PageListViewController.swift Outdated
@@ -466,12 +462,6 @@ class PageListViewController: AbstractPostListViewController, UIViewControllerRe
}

private func handleTrashPage(_ post: AbstractPost) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this entire method. Apologies for not doing this in the context menu PR!

momo-ozawa
momo-ozawa reviewed Nov 3, 2023
View reviewed changes
WordPress/Classes/ViewRelated/Pages/PageMenuViewModelTests.swift
@@ -85,7 +80,7 @@ final class PageMenuViewModelTests: CoreDataTestCase {
let expectedButtons: [[AbstractPostButton]] = [
[.view],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove [.view] from this test case to make it pass

momo-ozawa
momo-ozawa approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments - looks good otherwise!

@kean kean enabled auto-merge November 3, 2023 13:11
@kean
Copy link
Contributor Author

kean commented Nov 3, 2023

All addressed, thank you!

@kean kean force-pushed the task/minor-fixes-posts-and-pages branch from 8f3ca13 to 1e701e2 Compare November 3, 2023 13:48
@kean kean merged commit 15b1653 into trunk Nov 3, 2023
@kean kean deleted the task/minor-fixes-posts-and-pages branch November 3, 2023 14:32
@kean kean mentioned this pull request Nov 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momo-ozawa momo-ozawa momo-ozawa approved these changes

Assignees
No one assigned
Labels
Posts + Pages [Type] Task
Projects
None yet
Milestone
23.7
Development

Successfully merging this pull request may close these issues.
3 participants
@kean @wpmobilebot @momo-ozawa