-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Jetpack app name in store listing #21937
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
guarani
changed the title
Change app name in store listing
Change Jetpack app name in store listing
Nov 1, 2023
paulforgione
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for reference, the name of the app as it appears on a user's device is managed via xCode, so this change should only affect App Store Connect and the App Store listing.
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
mokagio
added a commit
that referenced
this pull request
Nov 2, 2023
This was done manually because the 23.5.1 hotfix train had to be interrupted after discovering some commits from 23.5 were missing from the branch. See: - #21937 - Internal ref: p8Qyks-7BS-p2#comment-3056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the app name in the App Store listing to "Jetpack for WordPress". It does not update the app name as shown on the user's device home screen.
To test: Verify that the change seems enough to update the app's name in the App Store listing for the Jetpack app. The WordPress app should be unchanged. It's not possible to actually test this until this is merged and the release has uploaded this change to App Store Connect. Once that happens, we can verify and be confident this change had the desired effect. Then we can submit the change for review by Apple.
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: Not applicable