Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Jetpack app name in store listing #21937

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Nov 1, 2023

This updates the app name in the App Store listing to "Jetpack for WordPress". It does not update the app name as shown on the user's device home screen.

To test: Verify that the change seems enough to update the app's name in the App Store listing for the Jetpack app. The WordPress app should be unchanged. It's not possible to actually test this until this is merged and the release has uploaded this change to App Store Connect. Once that happens, we can verify and be confident this change had the desired effect. Then we can submit the change for review by Apple.

Regression Notes

  1. Potential unintended areas of impact: Not applicable
  2. What I did to test those areas of impact (or what existing automated tests I relied on): Not applicable
  3. What automated tests I added (or what prevented me from doing so): Not applicable

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist: Not applicable

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 1, 2023

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@guarani guarani changed the title Change app name in store listing Change Jetpack app name in store listing Nov 1, 2023
@guarani guarani added this to the 23.5 milestone Nov 1, 2023
Copy link

@paulforgione paulforgione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for reference, the name of the app as it appears on a user's device is managed via xCode, so this change should only affect App Store Connect and the App Store listing.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21937-f32945a
Version23.5.1
Bundle IDcom.jetpack.alpha
Commitf32945a
App Center Buildjetpack-installable-builds #6655
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21937-f32945a
Version23.5.1
Bundle IDorg.wordpress.alpha
Commitf32945a
App Center BuildWPiOS - One-Offs #7638
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@jkmassel jkmassel merged commit abefbd2 into release/23.5.1 Nov 1, 2023
@jkmassel jkmassel deleted the update/app-name-in-store-listing branch November 1, 2023 21:41
mokagio added a commit that referenced this pull request Nov 2, 2023
This was done manually because the 23.5.1 hotfix train had to be
interrupted after discovering some commits from 23.5 were missing from
the branch.

See:

- #21937
- Internal ref: p8Qyks-7BS-p2#comment-3056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants