Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts & Pages: Update WordPressKit #21933

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Nov 1, 2023

Updates WordPressKit to point to a new version that has an updated tag parameter implementation.

To test:

  • Open Posts search
  • Verify that search by tags still work (warning: requires a wp.com site)
  • Repeat for Pages

Regression Notes

  1. Potential unintended areas of impact: Posts
  2. What I did to test those areas of impact (or what existing automated tests I relied on): n/a
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. Once you've bumped up the WPKit version to the newly released version / resolved conflicts, good to merge!

@kean kean force-pushed the task/add-tag-param branch 2 times, most recently from efa2947 to f0c4af8 Compare November 1, 2023 17:06
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 1, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21933-7466307
Version23.6
Bundle IDorg.wordpress.alpha
Commit7466307
App Center BuildWPiOS - One-Offs #7635
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 1, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21933-7466307
Version23.6
Bundle IDcom.jetpack.alpha
Commit7466307
App Center Buildjetpack-installable-builds #6652
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean force-pushed the task/add-tag-param branch from f0c4af8 to 7466307 Compare November 1, 2023 17:37
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@kean kean merged commit 6737579 into task/ui-modernization-posts-and-pages Nov 1, 2023
@kean kean deleted the task/add-tag-param branch November 1, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants