Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Posts & Pages: Fix empty state position #21927

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Posts & Pages: Fix empty state position #21927

merged 1 commit into from
Nov 1, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Oct 31, 2023 •
edited
Loading

Part of #21900

Regression Notes

  1. Potential unintended areas of impact: Posts & Pages list
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • [x I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean requested a review from momo-ozawa October 31, 2023 18:56
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

kean
kean commented Oct 31, 2023
View reviewed changes
WordPress/Classes/ViewRelated/Post/AbstractPostListViewController.swift
}

tableView.addSubview(noResultsViewController.view)
noResultsViewController.view.frame = tableView.frame.offsetBy(dx: 0, dy: -view.safeAreaInsets.top + 40)
Copy link
Contributor Author

@kean kean Oct 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional offset is pretty arbitrary. It is to make it visually appear centered.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21927-74ae213
Version23.5
Bundle IDorg.wordpress.alpha
Commit74ae213
App Center BuildWPiOS - One-Offs #7622
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21927-74ae213
Version23.5
Bundle IDcom.jetpack.alpha
Commit74ae213
App Center Buildjetpack-installable-builds #6639
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean merged commit 1643aad into task/ui-modernization-posts-and-pages Nov 1, 2023
@kean kean deleted the task/fix-no-results-position branch November 1, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momo-ozawa momo-ozawa momo-ozawa approved these changes

Assignees
No one assigned
Labels
Posts + Pages [Type] Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kean @wpmobilebot @momo-ozawa