Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Posts & Pages: Add swipe actions #21917

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Posts & Pages: Add swipe actions #21917

merged 3 commits into from
Nov 3, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Oct 30, 2023 •
edited
Loading

Fixes #21716

To test:

  • Verify that non-trashed posts & pages have "View" leading action
  • Verify that all posts have "Trash" or "Delete" actions
  • Verify that published posts have "Share" trailing actions
  • Verify that the same actions are available in search results
Simulator.Screen.Recording.-.iPhone.15.-.2023-11-02.at.19.05.24.mp4

Regression Notes

  1. Potential unintended areas of impact: Posts & Pages
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 30, 2023 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21917-b43ab86
Version23.6
Bundle IDorg.wordpress.alpha
Commitb43ab86
App Center BuildWPiOS - One-Offs #7676
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 30, 2023 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21917-b43ab86
Version23.6
Bundle IDcom.jetpack.alpha
Commitb43ab86
App Center Buildjetpack-installable-builds #6693
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Base automatically changed from task/ui-modernization-posts-and-pages to trunk November 1, 2023 20:50
@kean kean force-pushed the task/add-swipe-actions branch from 8da6eec to bb741b4 Compare November 2, 2023 23:09
@kean kean force-pushed the task/add-swipe-actions branch from bb741b4 to ee0ecd2 Compare November 2, 2023 23:11
@kean kean requested a review from momo-ozawa November 2, 2023 23:11
@kean kean added this to the 23.7 milestone Nov 2, 2023
@kean kean marked this pull request as ready for review November 2, 2023 23:12
@kean kean changed the title Posts & Lists: Add swipe actions Posts & Pages: Add swipe actions Nov 2, 2023
momo-ozawa
momo-ozawa reviewed Nov 3, 2023
View reviewed changes
WordPress/Classes/ViewRelated/Post/Search/PostSearchViewController.swift Outdated
@@ -18,6 +18,10 @@ final class PostSearchViewController: UIViewController, UITableViewDelegate, UIS

private var cancellables: [AnyCancellable] = []

private var postDelegate: InteractivePostViewDelegate {
listViewController as! InteractivePostViewDelegate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt using as? instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point. I simplified it here and removed the force unwrap. Looks like I also messed up the table delegate setup – fixed.

momo-ozawa
momo-ozawa approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@kean kean enabled auto-merge November 3, 2023 13:11
@kean kean merged commit 18c1ff0 into trunk Nov 3, 2023
@kean kean deleted the task/add-swipe-actions branch November 3, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momo-ozawa momo-ozawa momo-ozawa approved these changes

Assignees
No one assigned
Labels
Posts + Pages [Type] Task
Projects
None yet
Milestone
23.7
Development

Successfully merging this pull request may close these issues.

Posts & Pages: Add swipe actions
3 participants
@kean @wpmobilebot @momo-ozawa