-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posts & Pages: Add "deleting..." state #21907
Posts & Pages: Add "deleting..." state #21907
Conversation
Generated by 🚫 dangerJS |
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kean Nice improvements!
Restored post always shows up in drafts
This is the behavior on production as well. A post restored via the "Undo" action is always restored as a draft.
If we remove the alert, let's make sure to restore the posts in the original status / tab. Not sure if this is possible though - in which case we may have to keep the undo alert.
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-30.at.11.05.15.mp4
Footer cell w activity indicator becomes visible when post is trashed
After trashing a post, the footer cell becomes visible, and doesn't go away even after the post has been trashed.
I don't think we need to show the footer cell when deleting a post - wdyt?
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-30.at.10.20.15.mp4
…s-in-search Posts & Pages: Show latest posts in search
PostCoordinator
Notes:
To test:
Follow the steps from the video:
Simulator.Screen.Recording.-.iPhone.15.-.2023-10-27.at.16.40.29.mp4
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: