Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts & Pages: Add "deleting..." state #21907

Merged

Conversation

kean
Copy link
Contributor

@kean kean commented Oct 27, 2023

  • Move deletion and restoration to PostCoordinator
  • Remove the alert after tapping “Undo”: the post will simply appear where it was, which is enough
  • Fix an issue with SiteSettings view controller displayed in the prompt of 403 not having a “Done” button

Notes:

  • Permanent deletion is currently optimistically deletes the post (production behavior)
  • Pages don't have a respective status label

To test:

Follow the steps from the video:

Simulator.Screen.Recording.-.iPhone.15.-.2023-10-27.at.16.40.29.mp4

Regression Notes

  1. Potential unintended areas of impact: Posts
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 27, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21907-a2bd951
Version23.5
Bundle IDorg.wordpress.alpha
Commita2bd951
App Center BuildWPiOS - One-Offs #7613
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 27, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21907-a2bd951
Version23.5
Bundle IDcom.jetpack.alpha
Commita2bd951
App Center Buildjetpack-installable-builds #6633
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kean Nice improvements!

Restored post always shows up in drafts

This is the behavior on production as well. A post restored via the "Undo" action is always restored as a draft.

If we remove the alert, let's make sure to restore the posts in the original status / tab. Not sure if this is possible though - in which case we may have to keep the undo alert.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-30.at.11.05.15.mp4

Footer cell w activity indicator becomes visible when post is trashed

After trashing a post, the footer cell becomes visible, and doesn't go away even after the post has been trashed.

I don't think we need to show the footer cell when deleting a post - wdyt?

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-30.at.10.20.15.mp4

@kean kean mentioned this pull request Oct 30, 2023
27 tasks
kean and others added 2 commits October 31, 2023 09:50
@kean
Copy link
Contributor Author

kean commented Oct 31, 2023

I removed the "Undo" button as discussed in Slack p1698763051200289-slack-C04SFL0RP51 and added the footer bug, which I think is a regression introduced in one of the previous PRs, to #21900.

I also unintentionally merged #21913 in this PR, which was already approved.

@kean kean merged commit 5ea26cf into task/ui-modernization-posts-and-pages Nov 1, 2023
@kean kean deleted the task/add-deletion-loading-state branch November 1, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants