-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posts & Pages: Refactor table handler #1 #21874
Merged
kean
merged 11 commits into
task/ui-modernization-posts-and-pages
from
task/refactor-post-and-pages-p1
Oct 25, 2023
Merged
Posts & Pages: Refactor table handler #1 #21874
kean
merged 11 commits into
task/ui-modernization-posts-and-pages
from
task/refactor-post-and-pages-p1
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
momo-ozawa
approved these changes
Oct 25, 2023
@@ -95,10 +97,9 @@ final class PostListCell: UITableViewCell, Reusable { | |||
|
|||
contentView.addSubview(mainStackView) | |||
contentView.pinSubviewToAllEdges(mainStackView) | |||
contentView.backgroundColor = .systemBackground |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The screen had a .grouped
table view style, hence the different background color. Changing it to .plain
.
Base automatically changed from
task/remove-dead-code-page-list-table-view
to
task/ui-modernization-posts-and-pages
October 25, 2023 12:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ground work:
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: