Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts & Pages: Refactor table handler #1 #21874

Merged

Conversation

kean
Copy link
Contributor

@kean kean commented Oct 24, 2023

Some ground work:

  • Fix table section header size
  • Remove windowless cell (should be no need for it)
  • Remove ghosts
  • Remove estimated row height
  • Fix separator insets in post cells
  • Fix post cell background color
  • Use standard footer view

Regression Notes

  1. Potential unintended areas of impact: Posts & Pages
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21874-c00b68b
Version23.4
Bundle IDorg.wordpress.alpha
Commitc00b68b
App Center BuildWPiOS - One-Offs #7527
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21874-c00b68b
Version23.4
Bundle IDcom.jetpack.alpha
Commitc00b68b
App Center Buildjetpack-installable-builds #6554
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@@ -95,10 +97,9 @@ final class PostListCell: UITableViewCell, Reusable {

contentView.addSubview(mainStackView)
contentView.pinSubviewToAllEdges(mainStackView)
contentView.backgroundColor = .systemBackground
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually need to set the root view's backgroundColor to .systemBackground here. The default background color isn't what we want for dark mode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screen had a .grouped table view style, hence the different background color. Changing it to .plain.

Base automatically changed from task/remove-dead-code-page-list-table-view to task/ui-modernization-posts-and-pages October 25, 2023 12:31
@kean kean merged commit b977b37 into task/ui-modernization-posts-and-pages Oct 25, 2023
@kean kean deleted the task/refactor-post-and-pages-p1 branch October 25, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants