Posts & Pages: Move post actions to a context menu #21850

momo-ozawa · 2023-10-23T14:07:39Z

Description

Converted the Posts action sheet to a context menu
Post actions are divided into sections

Before	After

Notes

TODO
- Add comments action
- Adapt for Pages context menu
Using system images for the icons, for consistency - I can change this if needed

How to test

On the Posts list page, tap on the ellipsis button
Verify post actions are presented in a context menu
Verify post actions are in the correct grouping (ref: eYeHXEMDbnFptE40xUqZ2T-fi-836_5909)
Verify each post action has the expected result (no regressions)

Regression Notes

Potential unintended areas of impact
Post actions
What I did to test those areas of impact (or what existing automated tests I relied on)
Tested manually
What automated tests I added (or what prevented me from doing so)
n/a

PR submission checklist:

I have completed the Regression Notes.
I have considered adding unit tests for my changes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

Portrait and landscape orientations.
Light and dark modes.
Fonts: Larger, smaller and bold text.
High contrast.
VoiceOver.
Languages with large words or with letters/accents not frequently used in English.
Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
iPhone and iPad.
Multi-tasking: Split view and Slide over. (iPad)

kean · 2023-10-23T15:43:42Z

WordPress/Classes/ViewRelated/Post/PostMenuHelper.swift

+        switch self {
+        case .retry: UIImage()
+        case .view: UIImage(systemName: "eye")
+        case .publish: UIImage(systemName: "icon.globe")


There is no icon.globe but there is globe

I'd suggest using chart.bar because it has no fill

Done! 11ab0be

kean · 2023-10-23T15:51:41Z

WordPress/Classes/ViewRelated/Post/PostCardStatusViewModel.swift

+            buttons.append(.stats)
+        }
+
+        // TODO: Add reader and comments


Reader is out of the scope p1696870367221659/1696868289.514809-slack-C04SFL0RP51 (no need to update the comment)

Ah good shout, thanks for the reminder!

kean · 2023-10-23T15:55:54Z

WordPress/Classes/ViewRelated/Post/InteractivePostView.swift

@@ -2,5 +2,4 @@ import Foundation

 protocol InteractivePostView {
    func setInteractionDelegate(_ delegate: InteractivePostViewDelegate)


I hope I'm going to able to use PostListViewController implementation of the delegate in the search list. I think hit should work, but If not, I'll extract it to a separate class.

I think we'll end up having to extract it to a separate class, if we want to reuse it for pages. The pages screen doesn't use the delegate - it builds the action sheet straight in the class 😞

kean · 2023-10-23T16:05:39Z

WordPress/Classes/ViewRelated/Post/PostMenuHelper.swift

+
+        return buttons.map { button in
+            UIAction(title: button.title(for: post), image: button.icon, attributes: button.attributes, handler: { _ in
+                button.performAction(for: post, view: presentingView, delegate: delegate)


Not sure if there is a retain cycle, but I would suggest making the delegate weak just in case.

Done! 67b8085

kean · 2023-10-23T19:57:32Z

Using system images for the icons, for consistency - I can change this if needed

I think Chris wanted us to start adopting the Gutenberg icons. It can be done separately. It's not always easy to find what you need there.

kean

Approving, but with a couple of comments.

kean · 2023-10-23T19:59:43Z

WordPress/Classes/ViewRelated/Post/PostCardStatusViewModel.swift

-                }
-                buttons.append(.share)
-            }
+        if autoUploadInteractor.canRetryUpload(of: post) ||


I would suggest removing isInternetReachable. It's unreliable.

kean · 2023-10-23T20:05:27Z

WordPress/WordPressTest/PostCardCellTests.swift

-private typealias StatusMessages = PostCardStatusViewModel.StatusMessages
-
-class PostCardCellTests: CoreDataTestCase {
-    private var postCell: PostCardCell!


Is there a plan to re-implement (some of) these tests?

Yes! I'll add them in the next PR

peril-wordpress-mobile · 2023-10-24T10:16:04Z

	Warnings
⚠️	PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

wpmobilebot · 2023-10-24T11:22:54Z

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr21850-591f3c3
	Version	23.4
	Bundle ID	org.wordpress.alpha
	Commit	`591f3c3`
	App Center Build	WPiOS - One-Offs #7516

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot · 2023-10-24T11:26:56Z

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr21850-591f3c3
	Version	23.4
	Bundle ID	com.jetpack.alpha
	Commit	`591f3c3`
	App Center Build	jetpack-installable-builds #6543

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Momo Ozawa added 6 commits October 23, 2023 14:36

add post menu helper

692c28f

show system image icons for post menu

c3ccb63

divide buttons into sections

183fce8

remove PostActionSheet

2a13247

add reverse dns key for localized strings

2100ace

configure destructive title based on posts status

1fb9aa4

momo-ozawa added Posts + Pages [Type] Task UI Modernization labels Oct 23, 2023

momo-ozawa added this to the Pending milestone Oct 23, 2023

momo-ozawa requested a review from kean October 23, 2023 14:07

kean reviewed Oct 23, 2023

View reviewed changes

Momo Ozawa added 2 commits October 23, 2023 18:40

udpate menu icons

11ab0be

make delegate weak to avoid potential retain cycle

67b8085

momo-ozawa requested a review from kean October 23, 2023 17:45

kean approved these changes Oct 23, 2023

View reviewed changes

add explicit type

4972e37

fix CI build errors

591f3c3

momo-ozawa merged commit 63f1929 into task/ui-modernization-posts-and-pages Oct 24, 2023

momo-ozawa deleted the task/21717-post-context-menu branch October 24, 2023 12:16

momo-ozawa linked an issue Oct 27, 2023 that may be closed by this pull request

Posts & Pages: Update Post context menu #21717

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Posts & Pages: Move post actions to a context menu #21850

Posts & Pages: Move post actions to a context menu #21850

momo-ozawa commented Oct 23, 2023 •

edited

Loading

kean Oct 23, 2023

momo-ozawa Oct 23, 2023

kean Oct 23, 2023

momo-ozawa Oct 23, 2023

kean Oct 23, 2023

momo-ozawa Oct 23, 2023

kean Oct 23, 2023

momo-ozawa Oct 23, 2023

kean commented Oct 23, 2023

kean left a comment

kean Oct 23, 2023

kean Oct 23, 2023

momo-ozawa Oct 24, 2023

peril-wordpress-mobile bot commented Oct 24, 2023

wpmobilebot commented Oct 24, 2023

wpmobilebot commented Oct 24, 2023

		@@ -2,5 +2,4 @@ import Foundation

		protocol InteractivePostView {
		func setInteractionDelegate(_ delegate: InteractivePostViewDelegate)

Posts & Pages: Move post actions to a context menu #21850

Posts & Pages: Move post actions to a context menu #21850

Conversation

momo-ozawa commented Oct 23, 2023 • edited Loading

Description

Notes

How to test

Regression Notes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kean commented Oct 23, 2023

kean left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peril-wordpress-mobile bot commented Oct 24, 2023

wpmobilebot commented Oct 24, 2023

wpmobilebot commented Oct 24, 2023

momo-ozawa commented Oct 23, 2023 •

edited

Loading