Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Posts & Pages: Integrate new page cells in search #21844

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Posts & Pages: Integrate new page cells in search #21844

merged 2 commits into from
Oct 23, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Oct 20, 2023

Part of #21720

To test:

Simulator.Screen.Recording.-.iPhone.15.-.2023-10-20.at.10.54.27.mp4

Regression Notes

  1. Potential unintended areas of impact: Pages search
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean requested a review from momo-ozawa October 20, 2023 14:56
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21844-10eacda
Version23.4
Bundle IDorg.wordpress.alpha
Commit10eacda
App Center BuildWPiOS - One-Offs #7490
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21844-10eacda
Version23.4
Bundle IDcom.jetpack.alpha
Commit10eacda
App Center Buildjetpack-installable-builds #6516
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

momo-ozawa
momo-ozawa approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

Base automatically changed from task/pages-new-cells to task/ui-modernization-posts-and-pages October 23, 2023 13:21
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@kean kean merged commit 82bb44c into task/ui-modernization-posts-and-pages Oct 23, 2023
@kean kean deleted the task/new-page-cells-in-search branch October 23, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momo-ozawa momo-ozawa momo-ozawa approved these changes

Assignees
No one assigned
Labels
Posts + Pages [Type] Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kean @wpmobilebot @momo-ozawa