Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts & Pages: New design for pages cells #21842

Merged
merged 7 commits into from
Oct 23, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Oct 20, 2023

Fixes #21820, removes the Undo button, and update the Templates design.

Known issues:

  • The "Published/Edited" part is missing from the date label (should be done together with the Posts)
  • The list doesn't update when you create a new page (hope it's not a regression; I put it on the list)
  • The custom homepage is not displayed Issues with the template homepage support #21841

To test:

  • Create a new site with a FSE theme and verify that the Homepage template cell is displayed and has an updated design
  • Verify that "regular" pages have an updated design

Regression Notes

  1. Potential unintended areas of impact: Pages List
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 20, 2023

Warnings
⚠️ PR is not assigned to a milestone.
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@kean kean changed the base branch from trunk to task/ui-modernization-posts-and-pages October 20, 2023 14:20
@kean kean force-pushed the task/pages-new-cells branch from bbf4f66 to cebcffa Compare October 20, 2023 14:23
@kean kean requested a review from momo-ozawa October 20, 2023 14:27
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 20, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21842-a69c864
Version23.4
Bundle IDorg.wordpress.alpha
Commita69c864
App Center BuildWPiOS - One-Offs #7499
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 20, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21842-a69c864
Version23.4
Bundle IDcom.jetpack.alpha
Commita69c864
App Center Buildjetpack-installable-builds #6524
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I think we should use the same top / bottom margins in the homepage template cell and the "normal" pages cells - wdyt? cc: @osullivanchris

Current top / bottom margin = 12.0

badges.append(Strings.badgePosts)
}
if let displayDate = page.displayDate() {
badges.append(displayDate.capitalized)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you mentioned already, we'll need to prepend dates with "Published", "Edited", or "Scheduled". When we do, I think we can drop .capitalized as well as the .capitalizeFirstWord in PostListItemViewModel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove it once we add these labels.

@osullivanchris
Copy link

Looking good! I think we should use the same top / bottom margins in the homepage template cell and the "normal" pages cells - wdyt? cc: @osullivanchris

Sounds good. Some borders are indented some not. Am I right in saying the full-width ones are for the homepage template cell and for the end of the list? If so I think that works...by the way I don't really know the rules iOS has for indented or full-width so I just went with what looked best to me.

@kean
Copy link
Contributor Author

kean commented Oct 23, 2023

Good catch, I totally missed that on a simulator. I fixed both the margins and the separator insets:

Screenshot 2023-10-23 at 9 18 09 AM

@kean kean merged commit 2151deb into task/ui-modernization-posts-and-pages Oct 23, 2023
@kean kean deleted the task/pages-new-cells branch October 23, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Posts & Pages: Update Pages cell design
4 participants