-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posts & Pages: New design for pages cells #21842
Posts & Pages: New design for pages cells #21842
Conversation
Generated by 🚫 dangerJS |
bbf4f66
to
cebcffa
Compare
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I think we should use the same top / bottom margins in the homepage template cell and the "normal" pages cells - wdyt? cc: @osullivanchris
Current | top / bottom margin = 12.0 |
---|---|
badges.append(Strings.badgePosts) | ||
} | ||
if let displayDate = page.displayDate() { | ||
badges.append(displayDate.capitalized) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you mentioned already, we'll need to prepend dates with "Published", "Edited", or "Scheduled". When we do, I think we can drop .capitalized as well as the .capitalizeFirstWord in PostListItemViewModel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove it once we add these labels.
Sounds good. Some borders are indented some not. Am I right in saying the full-width ones are for the homepage template cell and for the end of the list? If so I think that works...by the way I don't really know the rules iOS has for indented or full-width so I just went with what looked best to me. |
Fixes #21820, removes the Undo button, and update the Templates design.
Known issues:
To test:
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: