Posts & Pages: Integrate new cells in search #21828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21828-2756f7c | |
| Version | 23.4 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 2756f7c | |
| App Center Build | WPiOS - One-Offs #7486 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21828-2756f7c | |
| Version | 23.4 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 2756f7c | |
| App Center Build | jetpack-installable-builds #6513 |
kean
force-pushed
the
task/search-advanced-filters
branch
from
79f9b89 to
adc64f9
Compare
Base automatically changed from
task/search-advanced-filters
to
task/ui-modernization-posts-and-pages
October 19, 2023 13:55
kean
force-pushed
the
task/search-new-cells
branch
from
882dc31 to
d342e7a
Compare
kean
force-pushed
the
task/search-new-cells
branch
from
d342e7a to
11445d8
Compare
kean
commented
Oct 19, 2023
| @@ -1,6 +1,87 @@ | |||
| { | |||
| "object": { | |||
| "pins": [ | |||
| { | |||
| "package": "AutomatticAbout", | |||
There was a problem hiding this comment.
Do you see the same package.resolved changes? Not sure if I should commit or remote those.
There was a problem hiding this comment.
I do. I think we're seeing these changes because they were deleted in bac6644
There was a problem hiding this comment.
If we revert the changes made in bac6644, we won't see package.resolved changes going forward, right?
There was a problem hiding this comment.
Hmm, OK let me revert that. I'll merge it with this PR.
momo-ozawa
approved these changes
Oct 20, 2023
Comment on lines
53
to
55
| viewModel.$title.sink { [titleAndSnippetLabel] in | ||
| titleAndSnippetLabel.attributedText = $0 | ||
| }.store(in: &cancellables) |
There was a problem hiding this comment.
[nit] Wdyt of renaming viewModel.title to viewModel.content, and titleAndSnippetLabel to contentLabel?
There was a problem hiding this comment.
Yes, this is better – renamed.
kean
force-pushed
the
task/search-new-cells
branch
from
f828c7e to
2756f7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates new cells in search and adds live highlighting I tested the performance and there is no need to move the highlighting to the background.
Simulator.Screen.Recording.-.iPhone.15.-.2023-10-19.at.11.25.05.mp4
Regression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: