Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts & Pages: Remove cell switcher from Posts List screen #21806

Conversation

momo-ozawa
Copy link
Contributor

Part of #21712

Description

  • Removes cell switcher
  • Removes ghost table view
  • Registers and displays new cell design

How to test

  • Go to the posts lists screen
  • Verify the cell switcher isn't displayed

Regression Notes

  1. Potential unintended areas of impact
    Post list screen

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 17, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21806-d7f67ce
Version23.4
Bundle IDorg.wordpress.alpha
Commitd7f67ce
App Center BuildWPiOS - One-Offs #7465
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 17, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21806-d7f67ce
Version23.4
Bundle IDcom.jetpack.alpha
Commitd7f67ce
App Center Buildjetpack-installable-builds #6493
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean
Copy link
Contributor

kean commented Oct 17, 2023

Code removals are the best.

Base automatically changed from task/21712-update-post-cell-design to task/ui-modernization-posts-and-pages October 18, 2023 16:47
@momo-ozawa momo-ozawa merged commit 60739f9 into task/ui-modernization-posts-and-pages Oct 19, 2023
@momo-ozawa momo-ozawa deleted the task/21712-remove-cell-switcher branch October 19, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants