Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts & Pages: Move authors filter button to navigation bar #21766

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Oct 14, 2023

Fixes #21715

To test:

  • Verify that the authors filters is now displayed in the navigation bar
  • Verify that the filter is available for both Posts and Pages
  • Verify that after a fresh install the default filter is "Everyone"
Screenshot 2023-10-13 at 9 32 39 PM

Regression Notes

  1. Potential unintended areas of impact: Posts & Pages
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean requested a review from momo-ozawa October 14, 2023 01:31
@kean kean added this to the 23.6 milestone Oct 14, 2023
@kean kean changed the title Move authors filter button to navigation bar Posts & Pages: Move authors filter button to navigation bar Oct 14, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 14, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21766-c9cfffd
Version23.4
Bundle IDorg.wordpress.alpha
Commitc9cfffd
App Center BuildWPiOS - One-Offs #7423
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 14, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21766-c9cfffd
Version23.4
Bundle IDcom.jetpack.alpha
Commitc9cfffd
App Center Buildjetpack-installable-builds #6452
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kean, the new authors filter looks great! A few things:

  • Should default to "Me" or "Everyone"? "Me" is the default filter on mobile iOS, but it's "Everyone" on web. cc: @zwarm @AjeshRPai
  • I don't see the author filter on Pages for a site that should display filters - this should be resolved by applying this change from trunk
Screenshot 2023-10-16 at 10 00 58

@zwarm
Copy link
Contributor

zwarm commented Oct 16, 2023

  • Should default to "Me" or "Everyone"? "Me" is the default filter on mobile, but it's "Everyone" on web.

@momo-ozawa - On Android, fresh install, "Everyone" is selected as the default. I vote for staying consistent with the web, but will go with the majority.

@kean
Copy link
Contributor Author

kean commented Oct 16, 2023

Other folks also agree, and there is an existing task for that #16593. I'm going with "Everyone" by default.

@kean kean force-pushed the task/move-authors-filter branch from f3670cc to c9cfffd Compare October 16, 2023 18:43
@kean kean requested a review from momo-ozawa October 16, 2023 18:44
@kean
Copy link
Contributor Author

kean commented Oct 16, 2023

@momo-ozawa, I addressed both of these issues. Thank you!

@kean kean merged commit b69129b into task/ui-modernization-posts-and-pages Oct 17, 2023
@kean kean deleted the task/move-authors-filter branch October 17, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants