Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts & Pages: Extract search to a separate screen (and ViewModel) #21745

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Oct 12, 2023

Extract search to a separate screen (and ViewModel)

To test:

  • Open the new search and verify that it's showing (some) local results (the way it searches will completely change in future versions)

Known issue: search results don't reload after you exit/re-enter. Please ignore it for now. There is actually a bunch of bugs, but the main goal was to unblock the development for the main screen, so it's all good. Next PR reworks the search.

Regression Notes

  1. Potential unintended areas of impact: Posts & Pages
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a (yet)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21745-16775d5
Version23.4
Bundle IDorg.wordpress.alpha
Commit16775d5
App Center BuildWPiOS - One-Offs #7362
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21745-16775d5
Version23.4
Bundle IDcom.jetpack.alpha
Commit16775d5
App Center Buildjetpack-installable-builds #6396
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Comment on lines +100 to +103
// let filter = filterSettings.currentPostListFilter()
// guard filter.hasMore else {
// return
// }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to commit / comment this out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm removing it in the future PRs replacing with a final implementation.

@kean kean merged commit b205847 into task/ui-modernization-posts-and-pages Oct 13, 2023
@kean kean deleted the task/extract-search branch October 13, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants