Posts & Pages: Native search

[kean]

Part of #21719.

This is the initial implementation that achieves the following:

search-with-refresh-control.mp4

@momo-ozawa, the search (and results) will now be handled entirely by PostSeachViewController, so feel free to drop/ignore any of the search code from the existing view controllers. It should make them much easier to maintain.

I think we should rework this a bit and use composition instead of inheritance. It’s almost always the right call, and it’s going to be easier to follow and maintain in the future.

To test: n/a for now

Regression Notes

1. Potential unintended areas of impact: Post & Pages
2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr21738-71ea539
	Version	23.4
	Bundle ID	org.wordpress.alpha
	Commit	71ea539
	App Center Build	WPiOS - One-Offs #7355

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr21738-71ea539
	Version	23.4
	Bundle ID	com.jetpack.alpha
	Commit	71ea539
	App Center Build	jetpack-installable-builds #6389

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[momo-ozawa]

LGTM! FYI I changed the base from trunk to our feature branch

[momo-ozawa]

Suggested change

	private let searchResultsViewController = PostSeachViewController()
	private let searchResultsViewController = PostSearchViewController()

[peril-wordpress-mobile]

	Warnings
⚠️	PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS