-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media: Thumbnails #21615
Merged
Merged
Media: Thumbnails #21615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
kean
force-pushed
the
task/media-foundation-thubmnails
branch
from
September 21, 2023 15:52
5567de8
to
702b0a0
Compare
kean
force-pushed
the
task/media-foundation-thubmnails
branch
from
September 21, 2023 19:02
3b956ea
to
8e553ec
Compare
momo-ozawa
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed reported regressions are resolved. Followed unit tests - works as described!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #21457
I made a couple of misguided changes in #21562 when it comes to thumbnails. This PR reverts some of them but keeps the performance improvements and adds more. These changes are hard to test manually, so I added unit tests. I'll add more as I add "official" support for GIFs, videos, and other formats.
In #21562, I tried switching to
media.absoluteThumbnailLocalURL
for all thumbnails, but it turned out it's used for large thumbnails that can be used fullscreen. Using small thumbnails breaks layout in the editor: recording (under the feature flag only).This PR has the following changes:
targetSize(forMediaSize,targetSize)
method to make sure this doesn't happen: recording. It's also a prerequisite for adding an "aspect" mode to the photos, like in the native Photos app.I'm not sure I like the use of
@MainActor
, but other than that, I think it's almost there now. Maybe a few minor tweaks. I'll likely move all of this work to the background in the next PR, but I need to figure out how to do it efficiently with Core Data.To Test
It's hard to test it manually, so I ended up writing a set of unit tests. Instead of duplicating all the test scenarios here, please follow the unit tests.
I asked not to test in the previous PRs because of the imminent upcoming changes. Now is the time to do some testing, preferably with a debugger.
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: