Remove MediaService.getMetadataFromVideoPressID #21569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21569-a149a7a | |
| Version | 23.2 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | a149a7a | |
| App Center Build | WPiOS - One-Offs #7118 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21569-a149a7a | |
| Version | 23.2 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | a149a7a | |
| App Center Build | jetpack-installable-builds #6162 |
mokagio
reviewed
Sep 15, 2023
Comment on lines
+2832
to
2836
| if let metadata, let originalURL = metadata.originalURL { | ||
| videoAttachment.updateURL(metadata.getURLWithToken(url: originalURL) ?? originalURL) | ||
| } | ||
| if let posterURL = metadata.posterURL { | ||
| if let metadata, let posterURL = metadata.posterURL { | ||
| videoAttachment.posterURL = metadata.getURLWithToken(url: posterURL) ?? posterURL |
There was a problem hiding this comment.
It took me a while to understand why let metadata was defined "twice".
This seems like a bit of an odd pattern metadata.getURLWithToken(url: originalURL) ?? originalURL, but not much to do about it here 🤔
I say odd because metadata owns originalURL, and it's calling an instance method passing it an instance property.
mokagio
approved these changes
Sep 15, 2023
Generated by 🚫 dangerJS |
|
Taking over merging this so it can be part of 23.3 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #21568, the
getMetadataFromVideoPressIDfunction simply makes an API call, I don't see how it needs to be in theMediaServicetype.There are some code changes around nullablity, because the
MediaService's re-declaration of the API call method turns an "nullable" declaration into "nonnull". The existing code has been using "nonnull" references and appears having no issue. Now that we are using the actual "nullable" references declared by theMediaServiceRemotefunction, we have to change the call sites too.Regression Notes
Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
None.
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: N/A