Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST][Gutenberg] Flatten inner blocks to fix call stack size exceeded crash #21552

Conversation

fluiddot
Copy link
Contributor

Fixes #

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@fluiddot fluiddot added [Status] DO NOT MERGE Gutenberg Editing and display of Gutenberg blocks. labels Sep 12, 2023
@fluiddot fluiddot self-assigned this Sep 12, 2023
@peril-wordpress-mobile
Copy link

Fails
🚫

This PR is tagged with '[Status] DO NOT MERGE' label.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21552-90aad51
Version23.2
Bundle IDorg.wordpress.alpha
Commit90aad51
App Center BuildWPiOS - One-Offs #7043
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21552-90aad51
Version23.2
Bundle IDcom.jetpack.alpha
Commit90aad51
App Center Buildjetpack-installable-builds #6087
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio
Copy link
Contributor

mokagio commented Jan 8, 2024

@fluiddot I'm going to close this given there hasn't been any activity in a long time and it looks like a test PR anyway. Feel free to reopen if needed.

@mokagio mokagio closed this Jan 8, 2024
@mokagio mokagio deleted the gutenberg/fix/call-stack-size-exceeded-flatten-solution branch January 8, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Status] DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants