Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Tests] Re-enable media picker tests with support to PHPicker #21447

Merged
merged 4 commits into from
Aug 28, 2023

Conversation

tiagomar
Copy link
Contributor

Description

This PR adds support to the new media picker, #21190, and re-enables tests (listed below) impacted by the changes.

EditorGutenbergTests.testAddGalleryBlock()
EditorGutenbergTests.testAddMediaBlocks()
EditorGutenbergTests.testAddRemoveFeaturedImage()
EditorGutenbergTests.testBasicPostPublishWithCategoryAndTag()

Testing

CI should be 🟢

@tiagomar tiagomar added the Testing Unit and UI Tests and Tooling label Aug 28, 2023
@tiagomar tiagomar added this to the Someday milestone Aug 28, 2023
@tiagomar tiagomar requested a review from kean August 28, 2023 13:47
@tiagomar tiagomar requested a review from a team as a code owner August 28, 2023 13:47
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21447-eeb8693
Version23.1
Bundle IDorg.wordpress.alpha
Commiteeb8693
App Center BuildWPiOS - One-Offs #6884
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21447-eeb8693
Version23.1
Bundle IDcom.jetpack.alpha
Commiteeb8693
App Center Buildjetpack-installable-builds #5924
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tiagomar tiagomar merged commit 9a96c92 into trunk Aug 28, 2023
@tiagomar tiagomar deleted the ui-tests-new-media-picker branch August 28, 2023 15:51
@tiagomar
Copy link
Contributor Author

The tests failed here because the .nativePhotoPicker Feature Flag is disabled in this branch. 😅 We can see the tests running correctly when merging into trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Unit and UI Tests and Tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants