Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the New Photo Post app shortcut #21369

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Remove the New Photo Post app shortcut #21369

merged 2 commits into from
Aug 22, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Aug 18, 2023

Part of #21190

We needed to either update this feature to support the new native photo picker or remove it. Because nobody was using it (<30 uses in the last 12 months), we decided to remove. Makes for a clearer shortcuts menu. Discussion: p1692303663191839-slack-C04SFL0RP51.

This is how this feature used to work:

Simulator.Screen.Recording.-.iPad.Air.5th.generation.-.2023-08-17.at.16.13.27.mp4

To test:

  • Verify that the remaining shortcuts still work

Regression Notes

  1. Potential unintended areas of impact: App Shortcuts (or, technically, "Quick Actions")
  2. What I did to test those areas of impact (or what existing automated tests I relied on): Manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 18, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21369-2d426ca
Version23.0
Bundle IDorg.wordpress.alpha
Commit2d426ca
App Center BuildWPiOS - One-Offs #6793
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 18, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21369-2d426ca
Version23.0
Bundle IDcom.jetpack.alpha
Commit2d426ca
App Center Buildjetpack-installable-builds #5833
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio
Copy link
Contributor

mokagio commented Aug 21, 2023

I'm going to bump this to the next release because we'll be code freezing 23.1 today and this hasn't been approved yet.

If this cannot wait two weeks and it's important that it makes it into this release, let me know and we'll organize a new beta once ready.

@mokagio mokagio modified the milestones: 23.1, 23.2 Aug 21, 2023
@kean kean requested review from momo-ozawa and removed request for guarani August 21, 2023 15:48
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 🧹

@kean kean force-pushed the task/remove-new-post branch from eee14fb to 2d426ca Compare August 22, 2023 13:47
@kean kean enabled auto-merge August 22, 2023 13:47
@kean kean merged commit f79d651 into trunk Aug 22, 2023
@kean kean deleted the task/remove-new-post branch August 22, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants