Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native picker prototype #21291

Closed
wants to merge 1 commit into from
Closed

Native picker prototype #21291

wants to merge 1 commit into from

Conversation

kean
Copy link
Contributor

@kean kean commented Aug 9, 2023

Native picker prototype.

To test:

Warning

If you are testing it on a simulator, don't select the first image with the flower.

Warning

The prototype doesn't support video yet.

Prototype recording (no customization): recoding.mp4.

TBD

Regression Notes

  1. Potential unintended areas of impact:
  2. What I did to test those areas of impact (or what existing automated tests I relied on):
  3. What automated tests I added (or what prevented me from doing so):

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 9, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21291-55067b6
Version23.0
Bundle IDcom.jetpack.alpha
Commit55067b6
App Center Buildjetpack-installable-builds #5707
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean force-pushed the task/native-media-picker branch from 9cc482b to 55067b6 Compare August 9, 2023 20:58
@kean kean added this to the Pending milestone Aug 9, 2023
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21291-55067b6
Version23.0
Bundle IDorg.wordpress.alpha
Commit55067b6
App Center BuildWPiOS - One-Offs #6668
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean marked this pull request as draft August 15, 2023 14:53
@kean kean closed this Aug 16, 2023
@jkmassel jkmassel deleted the task/native-media-picker branch July 26, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants