Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in ReaderDetailCommentsTableViewDelegate #21222

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Aug 1, 2023

Fixes #21202

To test:

  • Verify that when you open the post details from the Reader, the comments are displayed

I've spent some time investigating it, but I thought it was no longer warranted the time because of how few occurrences of this crash there are. The workaround is not great, but I think it's better than a crash.

Regression Notes

  1. Potential unintended areas of impact: Reader
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual testing
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean requested a review from staskus August 1, 2023 16:55
@kean kean added this to the Pending milestone Aug 1, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 1, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21222-ab6397d
Version22.9
Bundle IDorg.wordpress.alpha
Commitab6397d
App Center BuildWPiOS - One-Offs #6592
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 1, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21222-ab6397d
Version22.9
Bundle IDcom.jetpack.alpha
Commitab6397d
App Center Buildjetpack-installable-builds #5624
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workaround is not great, but I think it's better than a crash.

Agree 👍

@kean kean merged commit 902fe9b into trunk Aug 3, 2023
@kean kean deleted the fix/workaround-for-crash-in-comments branch August 3, 2023 11:53
@kean kean modified the milestones: Pending, 23.0 Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants