Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retain cycles in Site Creation #21066

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

crazytonyli
Copy link
Contributor

Relates to #21050.

I'll add PR comments regarding the two retain cycles.

Regression Notes

  1. Potential unintended areas of impact
    None.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    None.

  3. What automated tests I added (or what prevented me from doing so)
    None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist: N/A

Verified

This commit was signed with the committer’s verified signature.
crazytonyli Tony Li
@crazytonyli crazytonyli added this to the 22.9 milestone Jul 11, 2023
@crazytonyli crazytonyli requested review from jkmassel and mokagio July 11, 2023 23:13
@crazytonyli crazytonyli self-assigned this Jul 11, 2023
@@ -20,7 +20,7 @@ class TemplatePreviewViewController: UIViewController, NoResultsViewHost, UIPopo
@IBOutlet weak var footerView: UIView!
@IBOutlet weak var progressBar: UIProgressView!

internal var delegate: TemplatePreviewViewDelegate?
internal weak var delegate: TemplatePreviewViewDelegate?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LayoutPreviewViewController retains self: delegate = self

class LayoutPreviewViewController: TemplatePreviewViewController {
let completion: PageCoordinator.TemplateSelectionCompletion
let layout: PageTemplateLayout
init(layout: PageTemplateLayout, selectedPreviewDevice: PreviewDevice?, onDismissWithDeviceSelected: ((PreviewDevice) -> ())?, completion: @escaping PageCoordinator.TemplateSelectionCompletion) {
self.layout = layout
self.completion = completion
super.init(demoURL: layout.demoUrl, selectedPreviewDevice: selectedPreviewDevice, onDismissWithDeviceSelected: onDismissWithDeviceSelected)
delegate = self

@@ -8,7 +8,7 @@ final class SiteSegmentsStep: WizardStep {
return SiteSegmentsWizardContent(service: self.service, selection: self.didSelect)
}()

var delegate: WizardDelegate?
weak var delegate: WizardDelegate?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A retain cycle between WizardNavigation and SiteSegmentsStep

private func configureSteps() {
for var step in steps {
step.delegate = self
}
}

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21066-1ecffdc
Version22.7
Bundle IDorg.wordpress.alpha
Commit1ecffdc
App Center BuildWPiOS - One-Offs #6310
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21066-1ecffdc
Version22.7
Bundle IDcom.jetpack.alpha
Commit1ecffdc
App Center Buildjetpack-installable-builds #5333
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good.

  • Wizard delegate during side creation continues to be working ✅
  • TemplatePreview delegate during page creation continues to be working ✅

@crazytonyli crazytonyli merged commit fe10fe4 into trunk Jul 18, 2023
@crazytonyli crazytonyli deleted the weak-delegate-violation-fixes-7 branch July 18, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants