Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use weak reference to avoid a retain cycle #21040

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

crazytonyli
Copy link
Contributor

Fixes #21039.

See the issue details for how to verify the fix.

Regression Notes

  1. Potential unintended areas of impact
    None.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    None.

  3. What automated tests I added (or what prevented me from doing so)
    None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist: N/A

@crazytonyli crazytonyli added this to the 22.9 milestone Jul 10, 2023
@crazytonyli crazytonyli requested review from jkmassel and mokagio July 10, 2023 06:39
@crazytonyli crazytonyli self-assigned this Jul 10, 2023
@crazytonyli crazytonyli enabled auto-merge July 10, 2023 06:39
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21040-7dbb2e5
Version22.7
Bundle IDorg.wordpress.alpha
Commit7dbb2e5
App Center BuildWPiOS - One-Offs #6267
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21040-7dbb2e5
Version22.7
Bundle IDcom.jetpack.alpha
Commit7dbb2e5
App Center Buildjetpack-installable-builds #5291
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too easy

@crazytonyli crazytonyli merged commit 4cdc020 into trunk Jul 19, 2023
@crazytonyli crazytonyli deleted the fix-a-retain-cycle-in-reader-comments-screen branch July 19, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A memory leak in ReaderCommentsViewController
3 participants