Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks in ReaderStreamViewController #21015

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

crazytonyli
Copy link
Contributor

Issue

There are many delegate type references in Reader that are not declared as weak references.

Here are steps to reproduce the memory leak issue caused by them:

  1. Launch the app from Xcode
  2. Go to the Reader tab -> Discover
  3. Tap a topic in the "You might like" section: DIY, Baking, etc.
  4. You should see a "Topic" screen at this point, which is implemented as ReaderStreamViewController.
  5. Set a breakpoint at ReaderStreamViewController.deinit.
  6. Exit the "Topic" screen
  7. Xcode should stop at the ReaderStreamViewController.deinit breakpoint.

Performing the above steps on the trunk branch doesn't hit the deinit breakpoint, which means the view controller is not released.

You can test this PR by repeating the same steps on this PR branch and verify that Xcode stops at the deinit breakpoint.

Regression Notes

  1. Potential unintended areas of impact
    None.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    None.

  3. What automated tests I added (or what prevented me from doing so)
    None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist: N/A

@crazytonyli crazytonyli added this to the 22.8 milestone Jul 5, 2023
@crazytonyli crazytonyli requested review from jkmassel and mokagio July 5, 2023 23:41
@crazytonyli crazytonyli self-assigned this Jul 5, 2023
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21015-19c7682
Version22.7
Bundle IDorg.wordpress.alpha
Commit19c7682
App Center BuildWPiOS - One-Offs #6216
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21015-19c7682
Version22.7
Bundle IDcom.jetpack.alpha
Commit19c7682
App Center Buildjetpack-installable-builds #5242
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My breakpoint hit

When going from the default Read home screen, "Following" to "Discover":

image

When going from back from "Discover" > Tap "Nature" > "Nature" ReaderStreamViewController to "Discover":

Screenshot 2023-07-07 at 3 57 18 pm

@mokagio
Copy link
Contributor

mokagio commented Jul 7, 2023

Taking over merging to make sure this will land on trunk before the upcoming 22.8 code freeze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants