Fix memory leaks in ReaderStreamViewController #21015
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There are many delegate type references in Reader that are not declared as weak references.
Here are steps to reproduce the memory leak issue caused by them:
ReaderStreamViewController
.ReaderStreamViewController.deinit
.ReaderStreamViewController.deinit
breakpoint.Performing the above steps on the trunk branch doesn't hit the
deinit
breakpoint, which means the view controller is not released.You can test this PR by repeating the same steps on this PR branch and verify that Xcode stops at the
deinit
breakpoint.Regression Notes
Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
None.
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: N/A